feat: Expose device orientation via /wda/deviceOrientation#1162
Open
anton-yereshchenko wants to merge 2 commits into
Open
feat: Expose device orientation via /wda/deviceOrientation#1162anton-yereshchenko wants to merge 2 commits into
anton-yereshchenko wants to merge 2 commits into
Conversation
… add integration tests
| @property (strong, nonatomic, readonly) NSDictionary *fb_rotationMapping; | ||
|
|
||
| /** | ||
| The current physical device orientation represented as a WebDriver orientation string, |
There was a problem hiding this comment.
is there any reason to limit possible values by only these constants? Lets have a new string mapping that reflects properly what XCUIDevice.sharedDevice.fb_deviceOrientation returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
GET /wda/deviceOrientationendpoint that returns the physical device orientation.Motivation
The existing
GET /orientationreports the app's interface orientation (application.interfaceOrientation) and collapses everything toPORTRAIT/LANDSCAPE. This new endpoint exposes the raw physicalUIDeviceOrientation(XCUIDevice.orientation), which is useful when an app locks its UI but the device is physically rotated, and preserves the finer-grained values (landscape left/right, portrait upside-down).Changes
GET /wda/deviceOrientationroute (with and without session)fb_deviceOrientationto theXCUIDevice (FBRotation)category, mappingUIDeviceOrientationto the WebDriver orientation string (sameswitchstyle as the existingFBInterfaceOrientationFromDeviceOrientation)handleGetDeviceOrientation:simply delegates toXCUIDevice.sharedDevice.fb_deviceOrientation"UNKNOWN"for non-interface orientations (face up/down/unknown)How to test
GET /wda/deviceOrientation→ returns the current device orientation (PORTRAIT,LANDSCAPE,UIA_DEVICE_ORIENTATION_LANDSCAPERIGHT,UIA_DEVICE_ORIENTATION_PORTRAIT_UPSIDEDOWN, orUNKNOWN).