fix(symfony): include value-object transformers in JSON-LD streamer locator#7968
Merged
Conversation
soyuka
force-pushed
the
fix-jsonstream
branch
4 times, most recently
from
3ab176e to
18b0b81
Compare
…ocator
Symfony 8.1 split json_streamer.value_transformer into property_value_transformer
and value_object_transformer. The custom JSON-LD JsonStreamReader/Writer bypassed
Symfony's TransformerPass, so DateTimeInterface (and other value objects) were
missing from its locator — making the generator emit a Splitter::splitDict call
on date-time strings ("JSON is not valid").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony 8.1 split json_streamer.value_transformer into property_value_transformer and value_object_transformer. The custom JSON-LD JsonStreamReader/Writer bypassed Symfony's TransformerPass, so DateTimeInterface (and other value objects) were missing from its locator — making the generator emit a Splitter::splitDict call on date-time strings ("JSON is not valid").