ZOOKEEPER-5051: Avoid NPE closing 4lw connection during startup#2391
Open
PAC-MAJ wants to merge 2 commits into
Open
ZOOKEEPER-5051: Avoid NPE closing 4lw connection during startup#2391PAC-MAJ wants to merge 2 commits into
PAC-MAJ wants to merge 2 commits into
Conversation
6f17b3e to
fa9f51d
Compare
fa9f51d to
89dae72
Compare
Author
|
The latest failure appears to be a Jenkins infrastructure/agent issue. Could someone kindly rerun the precommit job? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a 4-letter command is sent while the ZooKeeper server is starting,
the connection close path can call
ZooKeeperServer.removeCnxn()beforestartdata()has initializedzkDb.This can trigger:
But this also hangs any client waiting for connection close.
Fix
Guard
ZooKeeperServer.removeCnxn()so it only delegates to zkDbwhen zkDb has already been initialized.
Test
Added
ZooKeeperServerTest#testRemoveCnxnBeforeStartData.The test creates a ZooKeeperServer but intentionally does not call
startdata(), then verifies thatremoveCnxn()does not throw.