ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25 by PDavid · Pull Request #2376 · apache/zookeeper

PDavid · 2026-04-23T12:08:05Z

Replaced maven.compiler.source + maven.compiler.target with a single maven.compiler.release=17
Removed maven.compiler.release property from m2e profile (it now inherits from main properties).
Removed jdk-release-flag Maven profile as it is not required anymore (maven.compiler.release=17 makes sure our build is compatible with Java 17).
Upgrade Mockito to 5.23.0 for JDK25: As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.
Switch GH: Action workflows and Jenkins builds to JDK 17 and 25
Upgrade spotbugs to support Java 25
- Upgraded spotbugs-maven-plugin to 4.9.3.0 and annotations to 4.9.3.
- Overrode ASM to 9.9.1 in the plugin dependencies to support JDK 25 (class file version 69).
- Added newly found bug patterns to excludeFindBugsFilter.xml - these are all pre-existing issues in the codebase that the newer SpotBugs detects but the old version couldn't.
Upgrade burningwave mockdns to 0.27.2 to support JDK25
Fix PrometheusMetricsProviderConfigTest: Exception message differs now a bit.
Upgrade JDK version in dev Dockerfile

PDavid · 2026-04-23T12:59:37Z

OK, Mockito 5 requires Java 11 or higher. It will not work with Java 8.
Mockito 4 supported Java 8 but that does not support Java 25.

Do we have to support Java 8 on ZooKeeper master branch?

kgeisz

LGTM

anmolnar · 2026-04-29T19:22:36Z

I think we can drop Java 8 support on the master branch. Please follow the discussion on the dev@ list.

PDavid · 2026-05-07T14:32:37Z

It seems only changing the Jenkins file did not worked out:

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 33: Tool type "jdk" does not have an install of "jdk_1.17_latest" configured - did you mean "jdk_1.8_latest"? @ line 33, column 13.
           jdk "jdk_1.17_latest"
               ^

https://ci-hadoop.apache.org/job/zookeeper-precommit-github-pr/job/PR-2376/5/console

Wrote to ASF Slack builds channel if thy can install / configure JDK 17 / JDK 25 for us.

anmolnar · 2026-05-07T18:58:48Z

It seems only changing the Jenkins file did not worked out:
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 33: Tool type "jdk" does not have an install of "jdk_1.17_latest" configured - did you mean "jdk_1.8_latest"? @ line 33, column 13.
           jdk "jdk_1.17_latest"
               ^
https://ci-hadoop.apache.org/job/zookeeper-precommit-github-pr/job/PR-2376/5/console

Wrote to ASF Slack builds channel if thy can install / configure JDK 17 / JDK 25 for us.

Might be (just guessing) jdk_17_latest and jdk_25_latest.

PDavid · 2026-05-08T11:01:21Z

SnapshotAndRestoreCommandTest.testSnapshotAndRestoreCommand_streaming failed in the GH: Action build. It succeeds for me locally so I guess it is just a flake here.

anmolnar

Lgtm. Please update and test Java version in dev/docker/Dockerfile as well.
Thanks!

PDavid · 2026-05-08T15:18:40Z

 #

-FROM maven:3.8.4-jdk-11
+FROM maven:3.9.6-eclipse-temurin-17


Since the old jdk and openjdk tags are deprecated, we should use the newer vendor-specific tags. Use Eclipse Temurin since we already use it in our GH: Actions workflows.

Also update Maven to 3.9.6 - it includes several improvements.

anmolnar

lgtm.

@eolivelli @ctubbsii PTAL

phunt · 2026-05-19T21:47:30Z

-1 - the documentation needs to be updated. Things like https://zookeeper.apache.org/doc/current/zookeeperAdmin.html - but please review all the docs to ensure covered.

Also the release notes (generated from JIRA) need to include this change, see : https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135860428#HowToReleaseusingmavenreleaseplugin-Createreleasenotesonreleasebranch

phunt · 2026-05-19T22:25:41Z

fwiw claude(sonnet) says:

Documentation Files

  zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md — The main change. Update the Required Software section (~line 128) to set JDK 17 as the minimum instead of JDK
   8. Also review the TLS cipher suites section (~lines 1742/1899) which discusses Java 8 vs Java 9+ behavior — some of that context may no longer be relevant.

  README.md — Remove the caveat at ~line 42 about needing JDK 8 update u211 or later when compiling with Java 1.8.

  zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md — No version text directly, but it links to zookeeperAdmin.md for requirements, so verify that reference
  still makes sense after the above change.

Build and CI files (not prose docs, but need to match):

  pom.xml — Update maven.compiler.source, maven.compiler.target, and maven.compiler.release from 1.8/8 to 17.

  .github/workflows/ci.yaml — Remove or replace the full-build-jdk8 matrix profile; make JDK 17 the primary.
  .github/workflows/e2e.yaml — Update jdk: [8, 11] to include 17 instead of 8.

The single most impactful documentation edit is zookeeperAdmin.md line ~128 — that's the canonical "required software" statement users and operators reference. The pom.xml
and CI workflow changes are mechanical but required to make the claim true.

As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.

- Upgraded spotbugs-maven-plugin to 4.9.3.0 and annotations to 4.9.3. - Overrode ASM to 9.9.1 in the plugin dependencies to support JDK 25 (class file version 69). - Added newly found bug patterns to excludeFindBugsFilter.xml - these are all pre-existing issues in the codebase that the newer SpotBugs detects but the old version couldn't.

to fix test issue: Caused by: io.github.toolfactory.jvm.util.ObjectProvider$BuildingException: Exception occurred while retrieving the implementation of class io.github.toolfactory.jvm.function.catalog.ConstructorInvokeFunction (jvm architecture: x64, jvm version: 25, jvm vendor: Eclipse Adoptium)

Exception message differs now a bit.

Also update Maven to 3.9.6 - it includes several improvements. Since the old `jdk` and `openjdk` tags are deprecated, we should use the newer vendor-specific tags. Use Eclipse Temurin since we already use it in our GH: Actions workflows.

- Replaced maven.compiler.source=17 + maven.compiler.target=17 with a single maven.compiler.release=17 - Removed maven.compiler.release property from m2e profile (it now inherits from main properties).

PDavid · 2026-05-21T14:26:25Z

+    <Bug pattern="EI_EXPOSE_REP"/>
+    <Bug pattern="EI_EXPOSE_REP2"/>
+    <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+    <Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
+    <Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE"/>
+    <Bug pattern="AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE"/>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Bug pattern="DCN_NULLPOINTER_EXCEPTION"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_METHOD"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_CLASS"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_FIELD"/>
+    <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
+    <Bug pattern="SS_SHOULD_BE_STATIC"/>
+    <Bug pattern="NP_UNWRITTEN_FIELD"/>
+    <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
+    <Bug pattern="MS_EXPOSE_REP"/>


Actually this suppression list are very broad. They are including real concurrency bugs (AT_STALE_THREAD_WRITE_OF_PRIMITIVE, AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE) and design issues (CT_CONSTRUCTOR_THROW, EI_EXPOSE_REP). Should we create a follow-up Jira to triage
and fix these incrementally?

Or should we suppress these by class so that these are not suppressed everywhere? We have 198 class/pattern combinations across these 16 patterns.

kgeisz approved these changes Apr 24, 2026

View reviewed changes

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from a72fee0 to e413971 Compare May 7, 2026 09:17

PDavid changed the title ~~ZOOKEEPER-5039: Upgrade Mockito to 5.23.0 for JDK25~~ ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25 May 7, 2026

anmolnar requested changes May 8, 2026

View reviewed changes

PDavid commented May 8, 2026

View reviewed changes

PDavid requested a review from anmolnar May 11, 2026 06:59

anmolnar approved these changes May 11, 2026

View reviewed changes

PDavid added 11 commits May 21, 2026 15:47

ZOOKEEPER-5039: Upgrade Mockito to 5.23.0 for JDK25

9a2dbaa

As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.

ZOOKEEPER-5039: Switch GH: Action workflows to JDK 17 and 25

d9de4c2

ZOOKEEPER-5039: Switch Jenkins workflows to JDK 17 and 25

c16e8fc

ZOOKEEPER-5039: Upgrade spotbugs to support JDK 17

b13cd12

ZOOKEEPER-5039: Fix PrometheusMetricsProviderConfigTest

c6611da

Exception message differs now a bit.

ZOOKEEPER-5039: Change Maven compiler source and target to 17

7ebeb3e

ZOOKEEPER-5039: Align Maven compiler Java versions

570ecd8

- Replaced maven.compiler.source=17 + maven.compiler.target=17 with a single maven.compiler.release=17 - Removed maven.compiler.release property from m2e profile (it now inherits from main properties).

ZOOKEEPER-5039: Update documentation

36b3f83

PDavid commented May 21, 2026

View reviewed changes

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from 7671da3 to 36b3f83 Compare May 21, 2026 14:26

anmolnar mentioned this pull request May 21, 2026

ZOOKEEPER-5038 Decouple HTTP admin server into a separate module. #2395

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25#2376

ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25#2376
PDavid wants to merge 11 commits into
apache:masterfrom
PDavid:ZOOKEEPER-5039-mockito-upgrade

PDavid commented Apr 23, 2026 •

edited

Loading

Uh oh!

PDavid commented Apr 23, 2026

Uh oh!

kgeisz left a comment

Uh oh!

anmolnar commented Apr 29, 2026

Uh oh!

PDavid commented May 7, 2026

Uh oh!

anmolnar commented May 7, 2026

Uh oh!

PDavid commented May 8, 2026

Uh oh!

anmolnar left a comment

Uh oh!

PDavid May 8, 2026

Uh oh!

anmolnar left a comment

Uh oh!

phunt commented May 19, 2026

Uh oh!

phunt commented May 19, 2026 •

edited

Loading

Uh oh!

PDavid May 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

PDavid commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PDavid commented Apr 23, 2026

Uh oh!

kgeisz left a comment

Choose a reason for hiding this comment

Uh oh!

anmolnar commented Apr 29, 2026

Uh oh!

PDavid commented May 7, 2026

Uh oh!

anmolnar commented May 7, 2026

Uh oh!

PDavid commented May 8, 2026

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

PDavid May 8, 2026

Choose a reason for hiding this comment

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

phunt commented May 19, 2026

Uh oh!

phunt commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PDavid May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PDavid commented Apr 23, 2026 •

edited

Loading

phunt commented May 19, 2026 •

edited

Loading

PDavid May 21, 2026 •

edited

Loading