Enable additional RuboCop spacing rules - #3723
Merged
Merged
Conversation
Client: rb Co-Authored-By: OpenAI Codex (GPT-5.6) <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables additional neutral RuboCop layout/spacing cops for the Ruby subtree and applies the corresponding auto-corrections across the Ruby library, benchmarks, specs, and integration tests.
Changes:
- Turn on a set of
Layout/Space*RuboCop rules inlib/rb/.rubocop.yml. - Apply spacing fixes around operators, delimiters, and separators across Ruby implementation and test/benchmark code.
- Normalize numeric/range/operator spacing in protocol specs and JSON protocol implementation.
Reviewed changes
Copilot reviewed 1 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/rb/integration/TestClient.rb | Adjusts assertion spacing in integration tests. |
| lib/rb/spec/json_protocol_spec.rb | Normalizes float division spacing in JSON protocol specs. |
| lib/rb/spec/compact_protocol_spec.rb | Normalizes float division spacing in compact protocol specs. |
| lib/rb/spec/binary_protocol_spec_shared.rb | Normalizes exponent/range-related operator spacing in shared binary protocol specs. |
| lib/rb/lib/thrift/transport/memory_buffer_transport.rb | Normalizes constant expression spacing. |
| lib/rb/lib/thrift/protocol/json_protocol.rb | Normalizes range and float division spacing in JSON protocol implementation. |
| lib/rb/lib/thrift/processor.rb | Normalizes string concatenation spacing in error construction. |
| lib/rb/benchmark/thin_server.rb | Normalizes indexing expression spacing. |
| lib/rb/benchmark/server.rb | Normalizes indexing expression spacing. |
| lib/rb/benchmark/benchmark.rb | Normalizes interpolation/concatenation spacing in formatting code. |
| lib/rb/.rubocop.yml | Enables additional RuboCop layout/spacing cops. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the remaining neutral RuboCop spacing rules for operators, separators, comments, lambdas, and delimiters, then apply their autocorrections across the Ruby library, benchmarks, specs, and integration tests.
This intentionally leaves interior array and hash spacing unenforced, preserving forms such as
[1, 2, 3]and{a: 5, b: 6}without creating avoidable churn.This follows the merged
Style/UnpackFirstPR #3722; its diff contains only this spacing layer.[skip ci]anywhere in the commit message to free up build resources.