Migrate to proper circuit breakers.#4432
Open
markrmiller wants to merge 1 commit into
Open
Conversation
Move circuit-breaker admission control out of SearchHandler and ContentStreamHandlerBase and into a new SolrQoSFilter that suspends requests asynchronously when a breaker is tripped, dispatching them once the breaker clears (modeled after Jetty's QoSFilter/QoSHandler). Internal intra-cluster shard requests bypass suspension to avoid distributed deadlock. When QoS queueing is disabled (the default), a tripped breaker still fails fast synchronously, preserving the prior handler-enforced behavior. Add GcOverheadCircuitBreaker. Rewrite MemoryCircuitBreaker to read post-GC live bytes from the old/tenured pool instead of a moving average of raw heap usage. TTL-cache CPU and load-average samples so high-QPS admission control does not repoll expensive OS/JVM signals per request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental Branch Not for contribution review.