SOLR-18237: Do not copy data before noggit parsing#4415
Open
psalagnac wants to merge 1 commit into
Open
Conversation
This removes the buffer with full data copy when deserializing collection state from Zookeeper data.
Contributor
|
this looks like it make sense, however it would be awesome if we had a micro benchmark here? |
dsmiley
reviewed
May 14, 2026
| @@ -0,0 +1,7 @@ | |||
| title: Do not copy full data for UTF8 to Java string conversion for deserializing a collection state | |||
| type: fixed | |||
Contributor
There was a problem hiding this comment.
users will not perceive this as a fix of a bug. It's "changed". But I'm skeptical it warrants a changelog at all.
Comment on lines
+297
to
+299
| // convert from bytes to chars on-the-fly and parse directly | ||
| // from that instead of going through intermediate buffers | ||
| Reader reader = new InputStreamReader(new ByteArrayInputStream(utf8, offset, length), UTF_8); |
Contributor
There was a problem hiding this comment.
this is definitely the most natural/clear way to do things instead of anything else. Maybe it's faster; I trust your judgement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18237
This removes the
char[]array buffer when parsing collection state (and other Json data). Instead, the UTF8 decoding is done on the fly using JVM tolling (which I guess will be faster).By default, the JSON parser has an internal buffer of 8K.