Skip to content

refactor mapreduce tests with async/await #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
emilygilberts wants to merge 16 commits into
base: master
Choose a base branch
from
+3,094 −3,235
Draft

refactor mapreduce tests with async/await #9176

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e380383
rewrite mapreduce upsert tests with async await
emilygilberts Feb 19, 2026
becd512
format: rm almost empty lines
emilygilberts Feb 26, 2026
f1a1b9c
use arrov functions in upsert
emilygilberts Feb 26, 2026
a9d2eb8
replace var with const or let for tests/mapreduce tests
emilygilberts Mar 20, 2026
863ab90
collation tests: use async and arrow fns and add mapToRows helper
emilygilberts Mar 25, 2026
2dea57a
refactor basic view tests with async and arrow fns
emilygilberts Mar 25, 2026
de0a673
refactor key options tests with async and arrow fns
emilygilberts Mar 25, 2026
2c03c01
refactor tests with builtin fucntions
emilygilberts Mar 26, 2026
9070229
es6 refactor tests
emilygilberts Apr 1, 2026
58818c3
es6 refactor and replace fin and promisify
emilygilberts Apr 1, 2026
21eb6db
replaced toString with template literals
emilygilberts Apr 1, 2026
6251a76
es6 refactor tests
emilygilberts Apr 1, 2026
7e8a4eb
remove lets and start naming things
emilygilberts Apr 8, 2026
39b92a5
undo arrow functions on view map/reduce and fetch
emilygilberts Apr 8, 2026
808f74e
es6 refactor
emilygilberts Apr 13, 2026
48e65f0
wrap in try catch for bad builtin function
emilygilberts Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 67 additions & 49 deletions tests/unit/test.mapreduce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,63 +6,81 @@ var upsert = PouchDB.utils.upsert;
var utils = PouchDB.utils.mapReduceUtils;

describe('test.mapreduce.js-upsert', function () {
it('should throw an error if the doc errors', function () {
return upsert({
get: function () {
return Promise.reject(new Error('a fake error!'));
}
}, 'foo')
.then(function () {
it('should throw an error if the doc errors', async function () {
try {
await upsert(
{
Copy link
Copy Markdown
Member

@janl janl Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a style nit, but I’d be okay with having the opening curlies start with the method: upsert({ to save a mostly empty line

get: function () {
return Promise.reject(new Error('a fake error!'));
},
},
'foo',
);

should.fail("Expected promise to be rejected");
})
.catch(function (err) {
} catch (err) {
err.message.should.equal("a fake error!");
});
});
it('should fulfill if the diff returns false', function () {
return upsert({
get: function () {
return Promise.resolve({ _rev: 'xyz' });
}
}, 'foo', function () {
return false;
}).then(function (res) {
res.updated.should.equal(false);
res.rev.should.equal('xyz');
});
}
});
it('should put if get throws 404', function () {
return upsert({
get: function () {
return Promise.reject({ status: 404 });

it('should fulfill if the diff returns false', async function () {
const res = await upsert(
{
get: function () {
return Promise.resolve({ _rev: 'xyz' });
},
},
put: function () {
return Promise.resolve({ rev: 'abc' });
}
}, 'foo', function () {
return { difference: "something" };
}).then(function (res) {
res.updated.should.equal(true);
res.rev.should.equal('abc');
});
'foo',
function () {
return false;
},
);

res.updated.should.equal(false);
res.rev.should.equal('xyz');
});
it('should error if it can\'t put', function () {
return upsert({
get: function () {
return Promise.resolve({ _rev: 'xyz' });

it('should put if get throws 404', async function () {
const res = await upsert(
{
get: function () {
return Promise.reject({ status: 404 });
},
put: function () {
return Promise.resolve({ rev: 'abc' });
},
},
'foo',
function () {
return { difference: "something" };
},
put: function () {
return Promise.reject(new Error('falala'));
}
}, 'foo', function () {
return { difference: "something" };
})
.then(function () {
);

res.updated.should.equal(true);
res.rev.should.equal('abc');
});

it('should error if it can\'t put', async function () {
try {
await upsert(
{
get: function () {
return Promise.resolve({ _rev: 'xyz' });
},
put: function () {
return Promise.reject(new Error('falala'));
},
},
'foo',
function () {
return { difference: "something" };
},
);

should.fail("Expected promise to be rejected");
})
.catch(function (err) {
} catch (err) {
err.message.should.equal("falala");
});
}
});
});

Expand Down
Loading