add changes to release resources when the channel becomes inactive#2241
add changes to release resources when the channel becomes inactive#2241frankpuppa wants to merge 2 commits into
Conversation
|
Hi Frank, Chris |
|
Could you please increase the log level for your additional log output to something "debug" or "trace"? "info" makes the drivers quite noisy. |
|
|
||
| @Override | ||
| public void channelInactive(ChannelHandlerContext ctx) throws Exception { | ||
| logger.info("channelInactive.. context: {}", ctx.name()); |
There was a problem hiding this comment.
Please set this to "debug" or "trace"
|
|
||
| @Override | ||
| public void channelInactive(ConversationContext<Message> context) { | ||
| logger.info("On ChannelInactive"); |
There was a problem hiding this comment.
Please set this to "debug" or "trace"
Hello Chris, |
…lc4x - fix(s7): S7HMuxImpl direct buffer leak per-message (PR apache#2542) - fix(s7): alarm-query directBuffer not released in S7ProtocolLogic and S7NonHProtocolLogic (PR apache#2543) - fix(s7,spi): decodeLargeReadResponse heap buffer not released in S7ProtocolLogic and S7NonHProtocolLogic - feat(spi): SharedExecutor — JVM-scoped thread pools replace per-connection ThreadPoolExecutors to prevent thread accumulation on reconnect (PR apache#2281) - fix(spi): RequestTransactionManager.shutdown() cancels in-flight requests without shutting down shared executor - feat(spi): channelInactive lifecycle hook on Plc4xProtocolBase and Plc4xNettyWrapper; all drivers release resources on TCP disconnect (PR apache#2241) - fix(eip): NPE in decodeSingleReadResponse when PLC returns error status and getData() is null (PR apache#2471) - fix(umas): align pom version to 0.14.0.B-SNAPSHOT and fix RequestTransactionManager constructor call Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
While I was looking into this issue I found out that there are two leaks. The first is related to the RequestTransactionManager and the other is from the NettyHashTimerTimeoutManager. As I was mentioning in the issue I opened last week, this leaks happens when the PLC goes offline and back online and the client tries to reconnecting to it in a cycle.
I was only able to test this on the modbus simulator which seems to work ok with the changes I made on this branch.
Please provide me a feedback or any consideration. I am attaching also a small video which shows that the resources are freed as expected.
Issue link
Screencast.2025-09-03.09.58.05.mp4