HDDS-16212. Avoid the per-group list copy in Recon ContainerKeyMapperHelper - #11058
Open
rich7420 wants to merge 1 commit into
Open
HDDS-16212. Avoid the per-group list copy in Recon ContainerKeyMapperHelper#11058rich7420 wants to merge 1 commit into
rich7420 wants to merge 1 commit into
Conversation
…Helper handlePutOMKeyEvent and handleKeyReprocess iterated getLocationList() for every version group, allocating a flattened list per group per key. The loop bodies only read getContainerID(), so iterate getLocationLists() (the backing locationVersionMap.values() view) with a nested loop and drop the allocation. handleKeyReprocess runs over the entire OM key table during Recon reprocess, so this removes one throwaway list per version group across the whole keyspace.
sarvekshayr
approved these changes
Aug 19, 2026
sarvekshayr
left a comment
sarvekshayr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rich7420 for working on this.
LGTM.
Contributor
|
@chungen0126 and @yandrey321, would you like to take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerKeyMapperHelper.handleKeyReprocess and handlePutOMKeyEvent iterate getLocationList() for every version group, but the loop body only reads getContainerID():
for (OmKeyLocationInfoGroup omKeyLocationInfoGroup : omKeyInfo.getKeyLocationVersions()) {
long keyVersion = omKeyLocationInfoGroup.getVersion();
for (OmKeyLocationInfo omKeyLocationInfo : omKeyLocationInfoGroup.getLocationList())
{ long containerId = omKeyLocationInfo.getContainerID(); ... }
}
getLocationList() is documented as not O(1); it flatten-copies into a new List. handleKeyReprocess runs over the entire OM key table during Recon reprocess (ParallelTableIteratorOperation), so a list is allocated per version group per key across the whole keyspace.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16212
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32219894034