HDDS-16189. Return application/xml for S3 error responses

[F64116045]

What changes were proposed in this pull request?

The makeBucket() test in MinIO's Mint test suite, included in the Ozone S3 compatibility report, exposed that S3 Gateway returns XML error bodies with Content-Type: text/plain.

OS3ExceptionMapper converts OS3Exception responses to XML but does not specify the response media type. Jersey therefore uses text/plain, causing clients such as the MinIO SDK to reject the response instead of parsing the S3 error.

This patch sets the response media type to application/xml and adds a unit test to verify it.

S3 REST error response reference: https://docs.aws.amazon.com/AmazonS3/latest/developerguide/ErrorResponses.html

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-16189

How was this patch tested?

mvn -pl :ozone-s3gateway test -Dtest=TestOS3Exceptions -DskipShade -DskipRecon -DskipDocs
mvn -pl :ozone-s3gateway test -DskipShade -DskipRecon -DskipDocs

CI: https://github.com/F64116045/ozone/actions/runs/31982282510

[chihsuan]

Thanks for the fix! @F64116045 The change itself is correct. However, I tested the curl command from the Jira description, and it still returns text/plain. It looks like it takes a different error path. Please see inline comments.

[chihsuan]

I think the change is correct, but I noticed that the exact reproduction of HDDS-16189 follows the authentication-error path, which bypasses OS3ExceptionMapper. Should we also set MediaType.APPLICATION_XML_TYPE in S3Utils.wrapOS3Exception() and add a test for that?

ozone/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3Utils.java

Lines 141 to 146 in 1a4486a

	public static WebApplicationException wrapOS3Exception(OS3Exception ex) {
	return new WebApplicationException(ex.getErrorMessage(), ex,
	Response.status(ex.getHttpCode())
	.entity(ex.toXml())
	.build());
	}

[F64116045]

Oops, I missed that the curl request stops at AuthorizationFilter and never reaches OS3ExceptionMapper.
Thanks a lot for catching this!

[F64116045]

Thanks, updated S3Utils.wrapOS3Exception() and added a test.

[chihsuan]

nit: This class now also tests OS3ExceptionMapper. Could we update the class Javadoc accordingly?

[F64116045]

Updated, thanks.

[F64116045]

@chihsuan Thanks a lot for the review and for catching the authentication-error path I missed. I've addressed the suggestions.

[Gargi-jais11]

Thanks @F64116045 for the patch. Overall LGTM!
Let's add integration test as well in AbstractS3SDKV1Tests and AbstractS3SDKV2Tests for end to end testing.

[F64116045]

Thanks @Gargi-jais11 for the review and suggestion, added the checks to both SDK v1 and v2 tests.