HDDS-15301. Malformed PutBlock request can mark container UNHEALTHY#10295
Open
peterxcli wants to merge 2 commits into
Open
HDDS-15301. Malformed PutBlock request can mark container UNHEALTHY#10295peterxcli wants to merge 2 commits into
peterxcli wants to merge 2 commits into
Conversation
Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A malformed client PutBlock request can cause the datanode to mark the target container
UNHEALTHY. The request should be rejected as a client-side malformed request, but currently it is mapped toIO_EXCEPTION, whichHddsDispatchertreats as a container write failure.This means a bad/misbehaving client can poison the active container and close the pipeline.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15301
How was this patch tested?
Unit test