HDDS-15239. Support persist StorageType on Datanode Container YAML#10246
Open
xichen01 wants to merge 4 commits into
Open
HDDS-15239. Support persist StorageType on Datanode Container YAML#10246xichen01 wants to merge 4 commits into
xichen01 wants to merge 4 commits into
Conversation
ivandika3
reviewed
May 13, 2026
chungen0126
approved these changes
May 14, 2026
Contributor
chungen0126
left a comment
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for the patch. LGTM. Just a nit.
| // If storageType participates in checksum calculation, when rolling back to older versions that don't | ||
| // support storageType, they would recalculate checksum without storageType field | ||
| // (as it's unknown to them), causing checksum mismatch and validation failure. | ||
| Yaml yaml = ContainerDataYaml.getYamlForContainerType( |
Contributor
There was a problem hiding this comment.
Please use ContainerDataYaml.getYamlForContainerType(this.containerType, withReplicaIndex); here. Alternatively, consider cleaning up the method getYamlForContainerType(ContainerType containerType, boolean withReplicaIndex) if it is no longer being invoked elsewhere.
Contributor
Author
There was a problem hiding this comment.
I cleaned up the method getYamlForContainerType(ContainerType containerType, boolean withReplicaIndex)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StorageTypefield will be added to theYAMLfile of the Datanode Container.StorageType.StorageTypewill be used for features such as Container replica migration.FYI:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15239
How was this patch tested?
unit test