KAFKA-20921: Make SCRAM metadata deeply immutable - #23128
Open
Gimini-3 wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex
Gimini-3
marked this pull request as ready for review
August 11, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes SCRAM metadata images deeply immutable.
ScramImagepreviously wrapped only the outer mechanisms map without copying it, leaving constructor aliases and nested credential maps mutable.ScramCredentialDataalso retained and exposed itsbyte[]components through constructors, accessors, and conversion methods.The change:
toRecord(), andtoCredential().Related work: KAFKA-19305 mentioned
ScramImageimmutability, but PR #19847 only updatedClientQuotaImageandTopicImage.Validation:
./gradlew :metadata:spotlessCheck./gradlew :metadata:testThis contribution is my original work and I license it to the project under the project's open source license.