KAFKA-20601: Allow static member rejoin when consumer group is full (4.2) - #23120
Open
chickenchickenlove wants to merge 1 commit into
Open
KAFKA-20601: Allow static member rejoin when consumer group is full (4.2)#23120chickenchickenlove wants to merge 1 commit into
chickenchickenlove wants to merge 1 commit into
Conversation
…pache#22356) Previously, a static member rejoining a full modern consumer group could be rejected by the max group size check before the coordinator resolved that it was replacing an existing static member. Now, the max size check allows existing static members by `instanceId` to proceed to the static member validation/replacement path. New members are still rejected when the consumer group is at capacity, and unreleased static instance IDs still fail with the appropriate exception. Reviewers: nileshkumar3 <nileshkumar3@gmail.com>, David Jacot <david.jacot@gmail.com> (cherry picked from commit e691934)
Contributor
Author
|
@dajac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22356 to the
4.2branch.The change cherry-picked without textual conflicts. The regression tests required a small adaptation because trunk stores partition epochs in assigned partitions, while the
4.2branch stores assignments asMap<Uuid, Set<Integer>>.Testing
./gradlew :group-coordinator:test --tests org.apache.kafka.coordinator.group.GroupMetadataManagerTest./gradlew :group-coordinator:checkstyleMain :group-coordinator:checkstyleTest spotlessCheck