Skip to content

IGNITE-28479 Fix Logging at INFO level without checking during GridCollisionManager start #12989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zstan merged 1 commit into from
Apr 9, 2026
Merged

IGNITE-28479 Fix Logging at INFO level without checking during GridCollisionManager start #12989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ore/src/main/java/org/apache/ignite/internal/managers/collision/GridCollisionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ public GridCollisionManager(GridKernalContext ctx) {
}
});
}
else
log.info("Collision resolution is disabled (all jobs will be activated upon arrival).");
else {
if (log.isInfoEnabled())
log.info("Collision resolution is disabled (all jobs will be activated upon arrival).");
}

if (log.isDebugEnabled())
log.debug(startInfo());
Expand Down
13 changes: 11 additions & 2 deletions ...es/core/src/test/java/org/apache/ignite/internal/GridCollisionManagerLoggingSelfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

/**
* Tests for making sure that {@link GridCollisionManager} logs about specific conditions at correct levels,
Expand Down Expand Up @@ -56,9 +57,17 @@ public void initLoggerMock() {
public void collisionResolutionDisabledMessageShouldBeLoggedAtInfoLevel() throws Exception {
GridCollisionManager mgr = new GridCollisionManager(collisionResolutionDisabledContext());

mgr.start();
boolean infoLevel = logger.isInfoEnabled();
when(logger.isInfoEnabled()).thenReturn(true);

verify(logger).info("Collision resolution is disabled (all jobs will be activated upon arrival).");
try {
mgr.start();

verify(logger).info("Collision resolution is disabled (all jobs will be activated upon arrival).");
}
finally {
when(logger.isInfoEnabled()).thenReturn(infoLevel);
}
}

/**
Expand Down
Loading