Do not throw error on list_tables, list_namespaces#3477
Open
rambleraptor wants to merge 1 commit into
Open
Conversation
ebyhr
approved these changes
Jun 10, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
I'm not a fan of this approach either, but I agree with following the Java implementation. I've noticed that list_views already employs this strategy.
Collaborator
Author
|
Error -> empty array isn't a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Java (and soon Go) implementations of Iceberg specify that if list_tables / list_namespaces aren't supported, they should return an empty array, not throw an error.
I'm not a huge fan of this personally, but I think it's best to match the reference implementation.
List Tables on Java
List Namespaces on Java
Are these changes tested?
Test included.
Are there any user-facing changes?