Skip to content

Serialize true false #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 6 commits into from
Oct 2, 2025
Merged

Serialize true false #2538

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e670617
update true and false class
nathanbijleveld Sep 26, 2025
527fc42
test serialization of true and false object
nathanbijleveld Sep 26, 2025
650e293
remove unused import
nathanbijleveld Sep 26, 2025
e092459
remove unused model_serializer
nathanbijleveld Sep 26, 2025
81ef2b0
fix linting issues
nathanbijleveld Oct 2, 2025
6c8d689
add docstring that got removed during fix of linting
nathanbijleveld Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pyiceberg/expressions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
literal,
)
from pyiceberg.schema import Accessor, Schema
from pyiceberg.typedef import L, StructProtocol
from pyiceberg.typedef import L, StructProtocol, IcebergRootModel
Comment thread
nathanbijleveld marked this conversation as resolved.
Outdated
from pyiceberg.types import DoubleType, FloatType, NestedField
from pyiceberg.utils.singleton import Singleton

Expand Down Expand Up @@ -362,8 +362,9 @@ def __getnewargs__(self) -> Tuple[BooleanExpression]:
return (self.child,)


class AlwaysTrue(BooleanExpression, Singleton):
class AlwaysTrue(BooleanExpression, Singleton, IcebergRootModel):
Comment thread
nathanbijleveld marked this conversation as resolved.
Outdated
"""TRUE expression."""
root: str = "true"
Comment thread
nathanbijleveld marked this conversation as resolved.

def __invert__(self) -> AlwaysFalse:
"""Transform the Expression into its negated version."""
Expand All @@ -378,8 +379,9 @@ def __repr__(self) -> str:
return "AlwaysTrue()"


class AlwaysFalse(BooleanExpression, Singleton):
class AlwaysFalse(BooleanExpression, Singleton, IcebergRootModel):
Comment thread
nathanbijleveld marked this conversation as resolved.
Outdated
"""FALSE expression."""
root: str = "false"
Comment thread
nathanbijleveld marked this conversation as resolved.

def __invert__(self) -> AlwaysTrue:
"""Transform the Expression into its negated version."""
Expand Down
2 changes: 2 additions & 0 deletions tests/expressions/test_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,7 @@ def test_not() -> None:

def test_always_true() -> None:
always_true = AlwaysTrue()
assert always_true.model_dump_json() == '"true"'
assert str(always_true) == "AlwaysTrue()"
assert repr(always_true) == "AlwaysTrue()"
assert always_true == eval(repr(always_true))
Expand All @@ -746,6 +747,7 @@ def test_always_true() -> None:

def test_always_false() -> None:
always_false = AlwaysFalse()
assert always_false.model_dump_json() == '"false"'
assert str(always_false) == "AlwaysFalse()"
assert repr(always_false) == "AlwaysFalse()"
assert always_false == eval(repr(always_false))
Expand Down
Loading