[VL][Delta] Add DELETE DV diagnostics benchmark#12217
Draft
malinjawi wants to merge 16 commits into
Draft
Conversation
Keep Delta DV DML row-index target scans on Spark unless native DML row-index scanning and native write are explicitly enabled. Preserve the Spark Project/Filter subtree above the fallback scan and add Delta 3.3/4.0 plan-shape coverage for metadata row-index on and off. Validation: JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests Validation: JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests Validation: git diff --cached --check
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-delete-diagnostics-benchmark
branch
from
96ac465 to
6c1aff8
Compare
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-delete-diagnostics-benchmark
branch
from
6c1aff8 to
8c10d31
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-delete-diagnostics-benchmark
branch
from
d399df9 to
0a1b008
Compare
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-delete-diagnostics-benchmark
branch
from
0a1b008 to
016838d
Compare
|
Run Gluten Clickhouse CI on x86 |
Route Delta DELETE commands with persistent deletion vectors through the Gluten-specific command while leaving metadata-only, full-table, and non-DV cases on the existing Delta path. Add Delta 3.3 and Delta 4.0 coverage for persistent DV DELETE routing and repeated deletion-vector updates. Validation: git diff --cached --check; mvn test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests; mvn test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests.
malinjawi
force-pushed
the
split/delta-dv-delete-diagnostics-benchmark
branch
from
016838d to
104a356
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
This is the next stacked Delta DV MoR slice after #12216. It adds a focused benchmark harness for persistent deletion-vector DELETE so we can measure the current correctness path before enabling native bitmap construction or target-scan shortcuts.
Stack order:
This PR should remain draft until the earlier correctness PR has native CI confidence and we attach runtime benchmark output from CI or a local native build.
Scope
DeltaDeleteDeletionVectorBenchmarkfor Delta 3.3 and Delta 4.0.Intentionally deferred
Validation
Local validation after rebasing onto
origin/split/delta-dv-delete-correctnessatbbb971f71cd4fc690258c54c59333b392f90a8aa:git diff --check origin/split/delta-dv-delete-correctness...HEADenv JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./build/mvn -q test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsenv JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./build/mvn -q test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsRuntime benchmark execution is still pending because this local Mac checkout cannot start the Velox backend without
darwin/aarch64/libgluten.dylib. The benchmark class is intentionally added as a draft/diagnostic harness so native CI or a compatible local native build can provide the measured output before review-ready status.