[GLUTEN-8232][VL] Followup to update doc for VCPKG dynamic openssl feature#12178
Open
zhouyuan wants to merge 3 commits into
Open
[GLUTEN-8232][VL] Followup to update doc for VCPKG dynamic openssl feature#12178zhouyuan wants to merge 3 commits into
zhouyuan wants to merge 3 commits into
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_vcpkg_dynamicopenssl_doc
branch
from
3d6c3b2 to
bf668b9
Compare
Signed-off-by: Yuan <yuanzhou@apache.org>
yaooqinn
approved these changes
May 29, 2026
philo-he
approved these changes
May 29, 2026
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Looks good overall. One minor comment. Thanks.
| 1. **vcpkg Configuration**: The `dynamic-openssl` feature is enabled in `vcpkg.json`, which includes OpenSSL with FIPS support | ||
| 2. **Triplet Override**: Custom vcpkg triplets (`x64-linux-avx.cmake` and `arm64-linux-neon.cmake`) detect the environment variable and switch OpenSSL from static to dynamic linkage | ||
| 3. **Build Process**: The `init.sh` script adds the `--x-feature=dynamic-openssl` flag to vcpkg install | ||
| 4. **Library Packaging**: OpenSSL shared libraries are excluded from static linking but must be available at runtime |
Member
There was a problem hiding this comment.
Should we add the following explicit clarification for users?
-
At runtime, LD_LIBRARY_PATH should point to the OS-provided OpenSSL package, which includes libssl.so, libcrypto.so, and the FIPS-certified fips.so, so that these libraries are loaded instead of the ones built at compile time by vcpkg.
-
Users should ensure compatibility between the OpenSSL libraries (libssl.so and libcrypto.so) used at link time and those available at runtime. We recommend using the same major version to avoid potential compatibility issues.
Contributor
There was a problem hiding this comment.
@zhouyuan can you also add the openssl version in vcpkg here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
follow up on #11444 to update doc
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Related issue: #8232