Skip to content

[BP-2.3][FLINK-39641][runtime-web] Fix unstable position of the Rescales Tab #28133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RocMarshal merged 1 commit into from
May 9, 2026
+8 −3
Merged

[BP-2.3][FLINK-39641][runtime-web] Fix unstable position of the Rescales Tab #28133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions flink-runtime-web/web-dashboard/src/app/pages/job/job-detail/status/job-status.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export class JobStatusComponent implements OnInit, OnDestroy {
urlLoading = true;
readonly listOfNavigation: RouterTab[];
private readonly checkpointIndexOfNavigation: number;
private readonly rescalesIndexOfNavigation: number;

webCancelEnabled = this.statusService.configuration.features['web-cancel'];
isHistoryServer = this.statusService.configuration.features['web-history'];
Expand All @@ -82,7 +81,6 @@ export class JobStatusComponent implements OnInit, OnDestroy {
// Create a copy to avoid mutating the shared config
this.listOfNavigation = [...(moduleConfig.routerTabs || JOB_MODULE_DEFAULT_CONFIG.routerTabs)];
this.checkpointIndexOfNavigation = this.checkpointIndexOfNav();
this.rescalesIndexOfNavigation = this.rescalesIndexOfNav();
}

ngOnInit(): void {
Expand Down Expand Up @@ -133,6 +131,11 @@ export class JobStatusComponent implements OnInit, OnDestroy {
return this.listOfNavigation.findIndex(item => item.path === 'rescales');
}

private getRescalesTabIndexAfter(path: string): number {
const index = this.listOfNavigation.findIndex(item => item.path === path);
return index >= 0 ? index + 1 : this.listOfNavigation.length;
}

private handleJobDetailChanged(data: JobDetailCorrect): void {
this.jobDetail = data;
const checkpointNavIndex = this.checkpointIndexOfNav();
Expand All @@ -150,7 +153,9 @@ export class JobStatusComponent implements OnInit, OnDestroy {
if (!shouldShowRescales && rescalesNavIndex > -1) {
this.listOfNavigation.splice(rescalesNavIndex, 1);
} else if (shouldShowRescales && rescalesNavIndex == -1) {
this.listOfNavigation.splice(this.rescalesIndexOfNavigation, 0, {
// Insert deterministically after configuration to avoid stale index issues across job transitions.
const insertIndex = this.getRescalesTabIndexAfter('configuration');
this.listOfNavigation.splice(insertIndex, 0, {
path: 'rescales',
title: 'Rescales'
});
Expand Down