[FLINK-39642][s3] Fix Illegal argument error message#28132
Open
Samrat002 wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39642][s3] Fix Illegal argument error message#28132Samrat002 wants to merge 1 commit intoapache:masterfrom
Samrat002 wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
spuru9
approved these changes
May 9, 2026
Contributor
spuru9
left a comment
There was a problem hiding this comment.
LGTM, CI failure looks unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Preconditions.checkArgumentin Flink uses a simplified formatter that only supports%splaceholders (not%d,%f, etc.). Three validation error messages inNativeS3FileSystemFactoryused%dfor numeric values, causing the format specifier to appear literally in the output while the actual value was appended in brackets —e.g.:
s3.upload.min.part.size must be at least 5MB (5242880 bytes), but was %d bytes [1048576]
s3.upload.max.concurrent.uploads must be positive, but was %d [0]
This fix replaces
%dwith%sso values are substituted correctly.Brief change log
%dwith%sin threePreconditions.checkArgumentformat strings inNativeS3FileSystemFactory(part size min, part size max, max concurrent uploads)Verifying this change
This change is already covered by existing tests:
NativeS3FileSystemFactoryTest#testPartSizeTooSmallThrowsExceptionNativeS3FileSystemFactoryTest#testPartSizeTooLargeThrowsExceptionNativeS3FileSystemFactoryTest#testInvalidMaxConcurrentUploadsThrowsExceptionDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?