[FLINK-39607][s3] Add missing Nullable annotation and precondition for config#28126
Open
Samrat002 wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39607][s3] Add missing Nullable annotation and precondition for config#28126Samrat002 wants to merge 1 commit intoapache:masterfrom
Samrat002 wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Contributor
Author
|
@gaborgsomogyi PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request cleans up null handling in the flink-s3-fs-native module by adding proper preconditions for non-nullable constructor parameters, annotating nullable fields explicitly, and replacing ad-hoc null && isEmpty() checks with StringUtils.isNullOrWhitespaceOnly.
Brief change log
!= null && !isEmpty()string checks in S3ClientProvider.Builder with StringUtils.isNullOrWhitespaceOnly for assumeRoleArn, assumeRoleExternalId, explicitRegion, and credentialsProviderClassesVerifying this change
Existing tests cover the affected code paths:
Does this pull request potentially affect one of the following parts:
Documentation
Was generative AI tooling used to co-author this PR?