fix: Handle java.sql date types compatibility in Excel read and write operations

[ongdisheng]

Closed: #714

Purpose of the pull request

This PR fixes a bug where using java.sql.Date with WriteCellData constructor throws an UnsupportedOperationException. The issue occurs because the original implementation calls toInstant() method which is not supported by java.sql.Date.

What's changed?

The WriteCellData Date constructor now uses Instant.ofEpochMilli(dateValue.getTime()) instead of dateValue.toInstant() as the getTime() method works for both java.util.Date and java.sql.Date.

Checklist

• I have read the Contributor Guide.
• I have written the necessary doc or comment.
• I have added the necessary unit tests and all cases have passed.

[Copilot]

Pull request overview

This PR fixes a bug where java.sql.Date instances would throw an UnsupportedOperationException when passed to the WriteCellData constructor. The fix changes the date conversion from using toInstant() (which is not supported by java.sql.Date) to using getTime() (which works for both java.util.Date and java.sql.Date).

• Changed the WriteCellData Date constructor to use Instant.ofEpochMilli(dateValue.getTime()) instead of dateValue.toInstant()
• Added comprehensive test coverage for java.sql.Date compatibility
• Updated date format in test data classes from Chinese format to standard ISO format for consistency

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
fesod/src/main/java/org/apache/fesod/sheet/metadata/data/WriteCellData.java	Fixed the Date constructor to handle both java.util.Date and java.sql.Date by using getTime() method instead of toInstant()
fesod/src/test/java/org/apache/fesod/sheet/celldata/CellDataWriteData.java	Added sqlDate field and updated date format to ISO format for testing
fesod/src/test/java/org/apache/fesod/sheet/celldata/CellDataReadData.java	Added corresponding sqlDate field for reading test data
fesod/src/test/java/org/apache/fesod/sheet/celldata/CellDataDataTest.java	Added test case that creates WriteCellData with java.sql.Date to verify the fix
fesod/src/test/java/org/apache/fesod/sheet/celldata/CellDataDataListener.java	Added assertion to verify java.sql.Date handling works correctly

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[delei]

Using the Date#getTime() incurs a loss of precision, as it only provides millisecond accuracy. Furthermore, might we consider supporting java.sql.Timestamp? I believe the unit test examples could be improved.

[ongdisheng]

Thank you for the feedback! I'll look into this and explore supporting java.sql.Timestamp as well. Will improve the test examples too.

[skytin1004]

Hi @ongdisheng, @delei

I was looking through #719 and tried reproducing the original "WriteCellData(Date)" issue locally.

It feels like the PR has grown a bit beyond the original "java.sql.Date" / "java.sql.Time" "toInstant()" problem.

Do you think it would be easier to review this in smaller pieces first starting with the constructor behavior and a few focused regression tests?

[psxjoy]

Hi @ongdisheng, @delei

I was looking through #719 and tried reproducing the original "WriteCellData(Date)" issue locally.

It feels like the PR has grown a bit beyond the original "java.sql.Date" / "java.sql.Time" "toInstant()" problem.

Do you think it would be easier to review this in smaller pieces first starting with the constructor behavior and a few focused regression tests?

Since so many conflicts, I will close this PR in 24hours. Welcome any contributions :)