Skip to content

branch-4.0: [opt](memory) Remove unused dbId field from CloudReplica #62079 #62597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dataroaring wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: [opt](memory) Remove unused dbId field from CloudReplica #62079 #62597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ public class CloudReplica extends Replica implements GsonPostProcessable {
= new ConcurrentHashMap<String, List<Long>>();
@SerializedName(value = "be")
private ConcurrentHashMap<String, Long> primaryClusterToBackend = null;
@SerializedName(value = "dbId")
private long dbId = -1;
@SerializedName(value = "tableId")
private long tableId = -1;
@SerializedName(value = "partitionId")
Expand Down Expand Up @@ -107,7 +105,6 @@ public CloudReplica(ReplicaContext context) {
public CloudReplica(long replicaId, Long backendId, ReplicaState state, long version, int schemaHash,
long dbId, long tableId, long partitionId, long indexId, long idx) {
super(replicaId, -1, state, version, schemaHash);
this.dbId = dbId;
this.tableId = tableId;
this.partitionId = partitionId;
this.indexId = indexId;
Expand Down Expand Up @@ -562,10 +559,6 @@ public boolean checkVersionCatchUp(long expectedVersion, boolean ignoreAlter) {
return true;
}

Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CloudReplica#getDbId() was removed, but there are still call sites on this branch that use it (e.g. CloudTabletRebalancer calls cloudReplica.getDbId() when looking up the database and building UpdateCloudReplicaInfo). This change will break compilation and/or runtime behavior unless those callers are migrated to obtain dbId from TabletMeta/TabletInvertedIndex (or the dbId getter/field is kept for this branch).

Suggested change
public long getDbId() {
return dbId;
}

Copilot uses AI. Check for mistakes.
public long getDbId() {
return dbId;
}

public long getTableId() {
return tableId;
}
Expand Down
Loading