-
Notifications
You must be signed in to change notification settings - Fork 2k
ci: add breaking change detector #21499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 24 commits
d128c07
968fc57
3500fee
b0f7cdf
dcb3cfc
8ec278a
e15d6a7
129e180
0a863bd
b3b6dde
95189de
97ee5b5
d5b1985
910501c
f40c07a
65779f4
6de3a14
1bd00c2
b3bf244
5286bab
10847a0
6d27da4
a903cae
83a2f39
8d99fba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Detect semver-incompatible (breaking) API changes in crates modified by a PR. | ||
| # | ||
| # Only public workspace crates that have file changes are checked. | ||
| # Internal crates (benchmarks, test-utils, sqllogictest, doc) are excluded. | ||
| # | ||
| # If breaking changes are found, a sticky comment is posted on the PR. | ||
| # The comment is removed automatically once the issues are resolved. | ||
|
|
||
| name: "Detect breaking changes" | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| check-semver: | ||
| name: Check semver | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| logs: ${{ steps.check_semver.outputs.logs }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| # For fork PRs, `origin` points to the fork, not the upstream repo. | ||
| # Explicitly fetch the base branch from the upstream repo so we have | ||
| # a valid baseline ref for both diff and semver-checks. | ||
| - name: Fetch base branch | ||
| run: git fetch https://github.com/${{ github.repository }}.git ${{ github.base_ref }}:refs/remotes/origin/${{ github.base_ref }} | ||
|
|
||
| - name: Determine changed crates | ||
| id: changed_crates | ||
| run: | | ||
| # Parse workspace members from root Cargo.toml, excluding internal crates | ||
| # that are not published / not part of the public API. | ||
| MEMBERS=$(sed -n '/^members = \[/,/\]/p' Cargo.toml | grep '"' | sed 's/.*"\(.*\)".*/\1/' \ | ||
| | grep -v -e '^benchmarks$' -e '^test-utils$' -e '^datafusion/sqllogictest$' -e '^datafusion/doc$') | ||
|
|
||
| # Diff against the base branch to find which files changed in this PR | ||
| CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }}...HEAD) | ||
|
|
||
| # For each workspace member, check if any of its files were modified. | ||
| # If so, extract the crate name from its Cargo.toml. | ||
| PACKAGES="" | ||
| for member in $MEMBERS; do | ||
| if echo "$CHANGED_FILES" | grep -q "^${member}/"; then | ||
| pkg=$(grep '^name\s*=' "$member/Cargo.toml" | head -1 | sed 's/.*=\s*"\(.*\)"/\1/') | ||
| if [ -n "$pkg" ]; then | ||
| PACKAGES="$PACKAGES $pkg" | ||
| fi | ||
| fi | ||
| done | ||
|
|
||
| PACKAGES=$(echo "$PACKAGES" | xargs) | ||
| echo "packages=$PACKAGES" >> "$GITHUB_OUTPUT" | ||
| echo "Changed crates: $PACKAGES" | ||
|
|
||
| # Only install toolchain and cargo-semver-checks if there are crates to check | ||
| - name: Install Rust toolchain | ||
| if: steps.changed_crates.outputs.packages != '' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the github runner already has rust installed so this step is unecessary probably? |
||
| uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - name: Install cargo-semver-checks | ||
| if: steps.changed_crates.outputs.packages != '' | ||
| run: cargo install cargo-semver-checks | ||
|
|
||
| - name: Run cargo-semver-checks | ||
| id: check_semver | ||
| if: steps.changed_crates.outputs.packages != '' | ||
| run: | | ||
| set +e | ||
| ARGS="" | ||
| for pkg in ${{ steps.changed_crates.outputs.packages }}; do | ||
| ARGS="$ARGS --package $pkg" | ||
| done | ||
|
|
||
| # Compare the PR's code against the base branch to detect breaking changes. | ||
| # Use tee to show output in the Actions log while also capturing it. | ||
| # Strip ANSI escape codes from the captured output for the PR comment. | ||
| cargo semver-checks --baseline-rev origin/${{ github.base_ref }} $ARGS 2>&1 | tee /tmp/semver-output.txt | ||
| EXIT_CODE=${PIPESTATUS[0]} | ||
| OUTPUT=$(sed 's/\x1b\[[0-9;]*m//g' /tmp/semver-output.txt) | ||
| echo "logs<<EOF" >> "$GITHUB_OUTPUT" | ||
| echo "$OUTPUT" >> "$GITHUB_OUTPUT" | ||
| echo "EOF" >> "$GITHUB_OUTPUT" | ||
| exit $EXIT_CODE | ||
|
|
||
| # Post or remove a sticky comment on the PR based on the semver check result. | ||
| comment-on-pr: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| name: Comment on pull request | ||
| runs-on: ubuntu-latest | ||
| needs: check-semver | ||
| if: always() | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| steps: | ||
| - name: Comment | ||
| if: ${{ needs.check-semver.result != 'success' }} | ||
| uses: marocchino/sticky-pull-request-comment@v2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought in general the ASF CI jobs are supposed to avoid using non github actions (unless it is on the whitelist) -- so I am surprised this works.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did not test the sticky pull request itself, just tested the breaking change detector |
||
| with: | ||
| header: pr-semver-check-error | ||
| message: | | ||
| Thank you for opening this pull request! | ||
|
|
||
| Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes made since the last release. | ||
|
|
||
| Details: | ||
|
|
||
| ``` | ||
| ${{ needs.check-semver.outputs.logs }} | ||
| ``` | ||
|
|
||
| # Remove the comment if the check passes (e.g. after the PR is updated) | ||
| - name: Delete comment | ||
| if: ${{ needs.check-semver.result == 'success' }} | ||
| uses: marocchino/sticky-pull-request-comment@v2 | ||
| with: | ||
| header: pr-semver-check-error | ||
| delete: true | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how to debug scripts like this -- can you please put this logic into an existing script (like maybe
ci/scripts/changed_packages.sh?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extracted along with creating comments