Skip to content
Open
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d128c07
ci: add breaking change detector
rluvaton Apr 9, 2026
968fc57
ci: run manually for now
rluvaton Apr 9, 2026
3500fee
add to existing ci job so i can test the workflow
rluvaton Apr 9, 2026
b0f7cdf
add permission
rluvaton Apr 9, 2026
dcb3cfc
try running
rluvaton Apr 9, 2026
8ec278a
fetch main
rluvaton Apr 9, 2026
e15d6a7
run on all branches
rluvaton Apr 9, 2026
129e180
run on changed crates
rluvaton Apr 9, 2026
0a863bd
only if changed
rluvaton Apr 9, 2026
b3b6dde
compare against last commit
rluvaton Apr 9, 2026
95189de
test: add temporary public function for semver breaking change testing
rluvaton Apr 9, 2026
97ee5b5
test: remove public function to trigger semver breaking change
rluvaton Apr 9, 2026
d5b1985
fix
rluvaton Apr 9, 2026
910501c
test: re-add temporary public function for semver testing
rluvaton Apr 9, 2026
f40c07a
test: remove public function to trigger semver breaking change
rluvaton Apr 9, 2026
65779f4
fix
rluvaton Apr 9, 2026
6de3a14
test: re-add temporary public function for semver testing
rluvaton Apr 9, 2026
1bd00c2
test: remove public function to trigger semver breaking change
rluvaton Apr 9, 2026
b3bf244
revert
rluvaton Apr 9, 2026
5286bab
Merge branch 'main' into automate-semver-breaking-api
rluvaton Apr 9, 2026
10847a0
add coments
rluvaton Apr 9, 2026
6d27da4
Merge remote-tracking branch 'origin/automate-semver-breaking-api' in…
rluvaton Apr 9, 2026
a903cae
add license
rluvaton Apr 9, 2026
83a2f39
Merge branch 'main' into automate-semver-breaking-api
rluvaton Apr 9, 2026
8d99fba
use script instead
rluvaton Apr 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions .github/workflows/breaking_changes_detector.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

# Detect semver-incompatible (breaking) API changes in crates modified by a PR.
#
# Only public workspace crates that have file changes are checked.
# Internal crates (benchmarks, test-utils, sqllogictest, doc) are excluded.
#
# If breaking changes are found, a sticky comment is posted on the PR.
# The comment is removed automatically once the issues are resolved.

name: "Detect breaking changes"

on:
pull_request:
branches:
- main

permissions:
contents: read

jobs:
check-semver:
name: Check semver
runs-on: ubuntu-latest
outputs:
logs: ${{ steps.check_semver.outputs.logs }}
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

# For fork PRs, `origin` points to the fork, not the upstream repo.
# Explicitly fetch the base branch from the upstream repo so we have
# a valid baseline ref for both diff and semver-checks.
- name: Fetch base branch
run: git fetch https://github.com/${{ github.repository }}.git ${{ github.base_ref }}:refs/remotes/origin/${{ github.base_ref }}

- name: Determine changed crates
id: changed_crates
run: |
# Parse workspace members from root Cargo.toml, excluding internal crates
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to debug scripts like this -- can you please put this logic into an existing script (like maybe ci/scripts/changed_packages.sh?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted along with creating comments

# that are not published / not part of the public API.
MEMBERS=$(sed -n '/^members = \[/,/\]/p' Cargo.toml | grep '"' | sed 's/.*"\(.*\)".*/\1/' \
| grep -v -e '^benchmarks$' -e '^test-utils$' -e '^datafusion/sqllogictest$' -e '^datafusion/doc$')

# Diff against the base branch to find which files changed in this PR
CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }}...HEAD)

# For each workspace member, check if any of its files were modified.
# If so, extract the crate name from its Cargo.toml.
PACKAGES=""
for member in $MEMBERS; do
if echo "$CHANGED_FILES" | grep -q "^${member}/"; then
pkg=$(grep '^name\s*=' "$member/Cargo.toml" | head -1 | sed 's/.*=\s*"\(.*\)"/\1/')
if [ -n "$pkg" ]; then
PACKAGES="$PACKAGES $pkg"
fi
fi
done

PACKAGES=$(echo "$PACKAGES" | xargs)
echo "packages=$PACKAGES" >> "$GITHUB_OUTPUT"
echo "Changed crates: $PACKAGES"

# Only install toolchain and cargo-semver-checks if there are crates to check
- name: Install Rust toolchain
if: steps.changed_crates.outputs.packages != ''
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the github runner already has rust installed so this step is unecessary probably?

uses: dtolnay/rust-toolchain@stable

- name: Install cargo-semver-checks
if: steps.changed_crates.outputs.packages != ''
run: cargo install cargo-semver-checks

- name: Run cargo-semver-checks
id: check_semver
if: steps.changed_crates.outputs.packages != ''
run: |
set +e
ARGS=""
for pkg in ${{ steps.changed_crates.outputs.packages }}; do
ARGS="$ARGS --package $pkg"
done

# Compare the PR's code against the base branch to detect breaking changes.
# Use tee to show output in the Actions log while also capturing it.
# Strip ANSI escape codes from the captured output for the PR comment.
cargo semver-checks --baseline-rev origin/${{ github.base_ref }} $ARGS 2>&1 | tee /tmp/semver-output.txt
EXIT_CODE=${PIPESTATUS[0]}
OUTPUT=$(sed 's/\x1b\[[0-9;]*m//g' /tmp/semver-output.txt)
echo "logs<<EOF" >> "$GITHUB_OUTPUT"
echo "$OUTPUT" >> "$GITHUB_OUTPUT"
echo "EOF" >> "$GITHUB_OUTPUT"
exit $EXIT_CODE

# Post or remove a sticky comment on the PR based on the semver check result.
comment-on-pr:
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
name: Comment on pull request
runs-on: ubuntu-latest
needs: check-semver
if: always()
permissions:
contents: read
pull-requests: write
steps:
- name: Comment
if: ${{ needs.check-semver.result != 'success' }}
uses: marocchino/sticky-pull-request-comment@v2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought in general the ASF CI jobs are supposed to avoid using non github actions (unless it is on the whitelist) -- so I am surprised this works.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test the sticky pull request itself, just tested the breaking change detector

with:
header: pr-semver-check-error
message: |
Thank you for opening this pull request!

Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes made since the last release.

Details:

```
${{ needs.check-semver.outputs.logs }}
```

# Remove the comment if the check passes (e.g. after the PR is updated)
- name: Delete comment
if: ${{ needs.check-semver.result == 'success' }}
uses: marocchino/sticky-pull-request-comment@v2
with:
header: pr-semver-check-error
delete: true
Loading