Skip to content

CI: build and run sqllogictests binary directly in extended workflow #20282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kosiew wants to merge 15 commits into from
Closed

CI: build and run sqllogictests binary directly in extended workflow #20282

Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2fa9377
Enhance CI workflow and optimize release profile settings
kosiew Feb 10, 2026
1b4dbee
fix: Include extended.yml and Cargo.toml in workflow trigger paths
kosiew Feb 11, 2026
be84d47
ci: run sqllogictest binary from crate dir
kosiew Feb 11, 2026
304d28d
revert fix: Include extended.yml and Cargo.toml in workflow trigger p…
kosiew Feb 11, 2026
7b5b2a9
feat: update release profile settings in Cargo.toml
kosiew Feb 11, 2026
8d9bcb8
trigger CI extended tests
kosiew Feb 9, 2026
3e64ee2
Revert "trigger CI extended tests"
kosiew Feb 11, 2026
e0ae244
formatting
kosiew Feb 11, 2026
cd967ba
Merge branch 'main' into extended-tests-20052
kosiew Feb 11, 2026
ceb7d76
fix: Update sqllogictest binary build process and adjust working dire…
kosiew Feb 12, 2026
882251a
fix: Simplify sqllogictest binary retrieval in extended tests workflow
kosiew Feb 12, 2026
2b5a995
test with cargo test
kosiew Feb 13, 2026
04b3bf1
Revert "test with cargo test"
kosiew Feb 13, 2026
937fab9
trigger ci test
kosiew Feb 23, 2026
b830912
PR20282 before merge main
kosiew Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/extended.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,19 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Build sqllogictest binary
run: |
# Cargo emits test binaries with hashed filenames under target/.../deps.
# We use head to pick the first matching sqllogictests artifact from the JSON stream.
TEST_BIN=$(cargo build --profile release-nonlto --features backtrace,parquet_encryption --package datafusion-sqllogictest --test sqllogictests --message-format=json | sed -n 's/.*"executable":"\([^"]*\)".*/\1/p' | head -n 1)
Copy link
Copy Markdown
Contributor

@alamb alamb Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very confused (similar to @nuno-faria ) why this is taking so much less time

I would be hesitant to merge this until we understand why this would make the CI run faster. It doesn't make any sense to me

As an interim step, can you try at least splitting the build and run steps so we can see the timings

So like the build would be

  cargo build --features backtrace,parquet_encryption --profile release-nonlto --test sqllogictests

And then the test can be run with the same command

          cargo test --features backtrace,parquet_encryption --profile release-nonlto --test sqllogictests -- --include-sqlite

That way we can at least see what is taking so long.

Copy link
Copy Markdown
Contributor Author

@kosiew kosiew Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs:

  1. cargo build, cargo test
image
  1. cargo build, use binary build to run test
image
  1. no cargo build, just cargo test
image

From the above interim results, only the binary build test improves the CI run.

Copy link
Copy Markdown
Contributor Author

@kosiew kosiew Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be away from Feb 14-21.

Copy link
Copy Markdown
Contributor

@nuno-faria nuno-faria Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the fix on #20101 (synced to main) to get the new times per test but it still took over 2 hours there: https://github.com/apache/datafusion/actions/runs/22101965398/job/63873808241?pr=20101. I don't know what could be different.

if [ -z "$TEST_BIN" ]; then
echo "Could not find sqllogictests test binary"
exit 1
fi
echo "TEST_BIN=$TEST_BIN" >> "$GITHUB_ENV"
- name: Run sqllogictest
working-directory: datafusion/sqllogictest
run: |
cargo test --features backtrace,parquet_encryption --profile release-nonlto --test sqllogictests -- --include-sqlite
# sqllogictests expects crate-relative paths for test data.
"$TEST_BIN" --include-sqlite
cargo clean