test: [Spark 4.1.1] unignore CachedBatchSerializerNoUnwrapSuite#4204
Merged
mbutrovich merged 1 commit intoapache:mainfrom May 4, 2026
Merged
test: [Spark 4.1.1] unignore CachedBatchSerializerNoUnwrapSuite#4204mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich merged 1 commit intoapache:mainfrom
Conversation
…he#4137) Accept Comet's equivalent columnar-to-row operator in the cached plan assertion. The serializer's goal is to avoid unwrapping the row conversion, which is preserved when Comet replaces ColumnarToRowExec with CometNativeColumnarToRow / CometColumnarToRow.
mbutrovich
approved these changes
May 4, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for testing this, @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4137.
Rationale for this change
The
CachedBatchSerializerNoUnwrapSuitetest in Spark 4.1.1 asserts that, underDefaultCachedBatchSerializerNoUnwrap, the cached plan retains a row-conversion operator on top of its columnar scan. With Comet enabled, Comet replaces Spark'sColumnarToRowExecwithCometNativeColumnarToRow(overCometNativeScan), which preserves the serializer's intended "don't unwrap" semantics but differs in class identity from the assertion.What changes are included in this PR?
WholeStageCodegenExec(ColumnarToRowExec(...))) or the equivalent Comet shape (anyorg.apache.spark.sql.comet.*plan node).How are these changes tested?
Ran
CachedBatchSerializerNoUnwrapSuitelocally against Spark 4.1.1 with Comet enabled — test passes.