Skip to content

chore: fix spark ansi sum incompatibility message#4111

Open
coderfender wants to merge 5 commits intoapache:mainfrom
coderfender:fix_comet_sum_compatbility_level
Open

chore: fix spark ansi sum incompatibility message#4111
coderfender wants to merge 5 commits intoapache:mainfrom
coderfender:fix_comet_sum_compatbility_level

Conversation

@coderfender
Copy link
Copy Markdown
Contributor

@coderfender coderfender commented Apr 27, 2026

Which issue does this PR close?

Closes #4074

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Comment thread spark/src/main/scala/org/apache/comet/serde/strings.scala Outdated
Incompatible(None)
} else {
Unsupported(None)
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to leverage the right reason to fallback based on the pattern here

@coderfender coderfender force-pushed the fix_comet_sum_compatbility_level branch from 0d481f4 to 2fdb835 Compare April 29, 2026 07:43
Comment thread spark/src/main/scala/org/apache/comet/serde/aggregates.scala
Comment thread spark/src/main/scala/org/apache/comet/serde/strings.scala Outdated
Comment thread spark/src/main/scala/org/apache/comet/serde/unixtime.scala
Copy link
Copy Markdown
Contributor Author

@coderfender coderfender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments to help with review

Comment thread spark/src/main/scala/org/apache/comet/serde/strings.scala
Comment thread spark/src/main/scala/org/apache/comet/serde/unixtime.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues found when documenting current expression incompatibilities

2 participants