-
Notifications
You must be signed in to change notification settings - Fork 304
test: add date_trunc DST regression test in non-UTC session timezone #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−0
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 62 additions & 0 deletions
62
spark/src/test/resources/sql-tests/expressions/datetime/trunc_timestamp_dst.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| -- Licensed to the Apache Software Foundation (ASF) under one | ||
| -- or more contributor license agreements. See the NOTICE file | ||
| -- distributed with this work for additional information | ||
| -- regarding copyright ownership. The ASF licenses this file | ||
| -- to you under the Apache License, Version 2.0 (the | ||
| -- "License"); you may not use this file except in compliance | ||
| -- with the License. You may obtain a copy of the License at | ||
| -- | ||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||
| -- | ||
| -- Unless required by applicable law or agreed to in writing, | ||
| -- software distributed under the License is distributed on an | ||
| -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| -- KIND, either express or implied. See the License for the | ||
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- Exercise Comet's native date_trunc on a timezone that observes DST. | ||
| -- CometTruncTimestamp marks non-UTC as Incompatible, so enable allowIncompatible | ||
| -- to force the native path and verify correctness against Spark. | ||
|
|
||
| -- Config: spark.comet.expression.TruncTimestamp.allowIncompatible=true | ||
| -- Config: spark.sql.session.timeZone=America/Los_Angeles | ||
|
|
||
| statement | ||
| CREATE TABLE test_trunc_dst(ts timestamp) USING parquet | ||
|
|
||
| statement | ||
| INSERT INTO test_trunc_dst VALUES | ||
| (timestamp('2024-11-03 06:30:00')), | ||
| (timestamp('2024-11-03 14:30:00')), | ||
| (timestamp('2024-03-10 05:30:00')), | ||
| (timestamp('2024-03-10 12:30:00')), | ||
| (timestamp('2024-11-15 12:00:00')), | ||
| (timestamp('2024-12-15 23:30:00')), | ||
| (timestamp('2024-07-15 10:00:00')), | ||
| (NULL) | ||
|
|
||
| -- DAY truncation on a time after fall-back (PST) produces midnight of the same | ||
| -- day, which is BEFORE the fall-back transition and should be in PDT. | ||
| query | ||
| SELECT ts, date_trunc('DAY', ts) FROM test_trunc_dst ORDER BY ts | ||
|
|
||
| -- HOUR truncation crossing DST boundaries. | ||
| query | ||
| SELECT ts, date_trunc('HOUR', ts) FROM test_trunc_dst ORDER BY ts | ||
|
|
||
| -- WEEK truncation can span DST transitions (the week of Nov 3 2024 starts Oct 28 PDT). | ||
| query | ||
| SELECT ts, date_trunc('WEEK', ts) FROM test_trunc_dst ORDER BY ts | ||
|
|
||
| -- MONTH truncation: Nov 15 PST truncated to MONTH gives Nov 1, which is PDT. | ||
| query | ||
| SELECT ts, date_trunc('MONTH', ts) FROM test_trunc_dst ORDER BY ts | ||
|
|
||
| -- QUARTER truncation: the motivating case from the PR (Dec PST -> Oct PDT). | ||
| query | ||
| SELECT ts, date_trunc('QUARTER', ts) FROM test_trunc_dst ORDER BY ts | ||
|
|
||
| -- YEAR truncation: Dec 15 PST truncated to YEAR gives Jan 1, which is PST too, so no DST crossing. | ||
| query | ||
| SELECT ts, date_trunc('YEAR', ts) FROM test_trunc_dst ORDER BY ts | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude suggests adding '2024-11-03 01:30:00' as a test date. The suspicion is that truncating to HOUR produces 1:00 AM, which is ambiguous on Nov 3 (it occurs in both PDT and PST). chrono's
.single()returnsNone, causing theunwrap()to panic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a separate test file for this case, confirming the current panic