chore: Remove config option for native_iceberg_compat#4019
Open
andygrove wants to merge 10 commits intoapache:mainfrom
Open
chore: Remove config option for native_iceberg_compat#4019andygrove wants to merge 10 commits intoapache:mainfrom
native_iceberg_compat#4019andygrove wants to merge 10 commits intoapache:mainfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially address #4020.
Rationale for this change
Removing support for
native_iceberg_compatreduces the maintenance burden of the project.This PR makes it impossible for users to select
native_iceberg_compatand stops running tests for that scan impl.Subsequent PRs will remove the implementation code.
What changes are included in this PR?
COMET_NATIVE_SCAN_IMPLconfig now only allowsautoornative_datafusionCometScanRuleno longer uses the value of config optionCOMET_NATIVE_SCAN_IMPLand just usesnative_datafusionscannative_iceberg_compatnative_iceberg_compathave been removedHow are these changes tested?