Skip to content

Multiple CD-ROM / ISO Support Per VM #13101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Damans227 wants to merge 28 commits into
base: main
Choose a base branch
from

add unit tests for CD-ROM handling and enforce limits in TemplateManager

893c6df
Select commit
Loading
Failed to load commit list.
Draft

Multiple CD-ROM / ISO Support Per VM #13101

add unit tests for CD-ROM handling and enforce limits in TemplateManager
893c6df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2026 in 1s

18.09% (+0.01%) compared to 1e512ab

View this Pull Request on Codecov

18.09% (+0.01%) compared to 1e512ab

Details

Codecov Report

❌ Patch coverage is 41.96721% with 177 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.09%. Comparing base (1e512ab) to head (893c6df).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/template/TemplateManagerImpl.java 39.75% 86 Missing and 14 partials ⚠️
...rc/main/java/com/cloud/vm/dao/VmIsoMapDaoImpl.java 0.00% 44 Missing ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 60.71% 7 Missing and 4 partials ⚠️
...apache/cloudstack/api/response/UserVmResponse.java 33.33% 8 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 7 Missing ⚠️
.../schema/src/main/java/com/cloud/vm/VmIsoMapVO.java 83.33% 3 Missing and 1 partial ⚠️
.../cloudstack/api/command/user/iso/DetachIsoCmd.java 0.00% 1 Missing ⚠️
...e/cloudstack/api/response/AttachedIsoResponse.java 95.23% 0 Missing and 1 partial ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13101      +/-   ##
============================================
+ Coverage     18.08%   18.09%   +0.01%     
- Complexity    16706    16748      +42     
============================================
  Files          6037     6041       +4     
  Lines        542437   542762     +325     
  Branches      66420    66476      +56     
============================================
+ Hits          98088    98225     +137     
- Misses       433333   433499     +166     
- Partials      11016    11038      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov