Skip to content

Add per-domain OAuth (Google, GitHub) provider support #12702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Damans227 wants to merge 57 commits into
base: main
Choose a base branch
from

Implement normalization of ROOT domain to null for global OAuth provi…

b056914
Select commit
Loading
Failed to load commit list.
Draft

Add per-domain OAuth (Google, GitHub) provider support #12702

Implement normalization of ROOT domain to null for global OAuth provi…
b056914
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2026 in 0s

18.09% (+0.16%) compared to 30e6c22

View this Pull Request on Codecov

18.09% (+0.16%) compared to 30e6c22

Details

Codecov Report

❌ Patch coverage is 38.23529% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.09%. Comparing base (30e6c22) to head (b056914).
⚠️ Report is 208 commits behind head on main.

Files with missing lines Patch % Lines
...tack/oauth2/api/command/ListOAuthProvidersCmd.java 0.00% 35 Missing ⚠️
...ack/oauth2/api/response/OauthProviderResponse.java 10.00% 26 Missing and 1 partial ⚠️
...he/cloudstack/oauth2/dao/OauthProviderDaoImpl.java 0.00% 21 Missing ⚠️
...cloudstack/oauth2/github/GithubOAuth2Provider.java 0.00% 17 Missing ⚠️
...th2/api/command/OauthLoginAPIAuthenticatorCmd.java 38.46% 14 Missing and 2 partials ⚠️
...pache/cloudstack/oauth2/OAuth2AuthManagerImpl.java 81.48% 6 Missing and 9 partials ⚠️
...ack/oauth2/api/command/UpdateOAuthProviderCmd.java 0.00% 12 Missing ⚠️
...k/oauth2/api/command/RegisterOAuthProviderCmd.java 12.50% 6 Missing and 1 partial ⚠️
...cloudstack/oauth2/google/GoogleOAuth2Provider.java 70.00% 6 Missing ⚠️
...che/cloudstack/oauth2/OAuth2UserAuthenticator.java 16.66% 4 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12702      +/-   ##
============================================
+ Coverage     17.92%   18.09%   +0.16%     
- Complexity    16154    16754     +600     
============================================
  Files          5939     6037      +98     
  Lines        533181   542837    +9656     
  Branches      65237    66488    +1251     
============================================
+ Hits          95585    98230    +2645     
- Misses       426856   433570    +6714     
- Partials      10740    11037     +297

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov