Skip to content

chore: use npm ci instead of npm install in server.py --build flag #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deacon-mp wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: use npm ci instead of npm install in server.py --build flag #3331

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9780c2
chore: replace npm install with npm ci in server.py --build flag
deacon-mp Mar 15, 2026
ea1898a
fix: address Copilot review feedback
deacon-mp Mar 16, 2026
96e4089
Replace FileNotFoundError with warning log when package-lock.json mis…
deacon-mp Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,15 @@ def list_str(values):
if args.build:
if os.path.exists(f"{MAGMA_PATH}") and len(os.listdir(MAGMA_PATH)) > 0:
logging.info("Building VueJS front-end.")
subprocess.run(["npm", "install"], cwd=MAGMA_PATH, check=True)
package_lock = os.path.join(MAGMA_PATH, "package-lock.json")
if os.path.isfile(package_lock):
subprocess.run(["npm", "ci"], cwd=MAGMA_PATH, check=True)
else:
raise FileNotFoundError(
f"package-lock.json not found at {package_lock}. "
"A lockfile is required for reproducible builds. "
"Commit package-lock.json or run 'npm install' locally to generate it."
)
Comment on lines +294 to +299
Comment on lines +290 to +299
subprocess.run(["npm", "run", "build"], cwd=MAGMA_PATH, check=True)
logging.info("VueJS front-end build complete.")
else:
Expand Down
Loading