GH-50624: [C++][Compute] Tighten case_when exact dispatch for parameterized types

[zanmato1984]

Rationale for this change

case_when exact dispatch was too permissive for parameterized value types. When the value arguments were registered by type id only, DispatchExact could incorrectly accept incompatible concrete types and return successful but corrupted results instead of failing or falling back to DispatchBest.

This fixes #50624.

What changes are included in this PR?

• rename the case_when exact-match helper to AllValueTypesMatchConstraint() to make its intent explicit
• apply the same exact-match constraint across case_when value kernels so exact dispatch only accepts identical value DataTypes
• add regression coverage for mismatched parameterized value types, including fixed_size_binary, list, fixed_size_list, struct, and dictionary exact-dispatch mismatches

Are these changes tested?

Yes.

This PR extends TestCaseWhen.DispatchExact and adds TestCaseWhen.ParameterizedValueTypeMismatch. I also ran targeted arrow-compute-scalar-if-else-test coverage for:

• TestCaseWhen.DispatchExact
• TestCaseWhen.DispatchBest
• TestCaseWhen.ParameterizedValueTypeMismatch

Are there any user-facing changes?

Yes.

case_when now rejects incompatible parameterized value types that previously could be incorrectly exact-dispatched, which could lead to corrupted results.

This PR contains a "Critical Fix". It fixes a bug where case_when could return successful but corrupted results for incompatible parameterized value types.

• GitHub Issue: [C++][Compute] case_when can accept incompatible parameterized value types and return corrupted results #50624

[Copilot]

Pull request overview

This PR tightens case_when kernel selection so exact dispatch only accepts identical concrete DataTypes for value arguments (including parameterized/nested types), preventing incorrect kernel matches that could previously yield corrupted results.

Changes:

• Renames the exact-dispatch helper to AllValueTypesMatchConstraint() and generalizes it to enforce identical value argument DataTypes.
• Applies the same exact-match constraint across all case_when value kernels (primitive, binary, fixed-size binary, decimals, and nested).
• Adds regression tests covering exact-dispatch matching/failing for parameterized types and runtime failures for mismatched parameterized value types.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
cpp/src/arrow/compute/kernels/scalar_if_else.cc	Enforces identical concrete value DataTypes via a shared match constraint for all case_when kernels to prevent unsafe exact dispatch.
cpp/src/arrow/compute/kernels/scalar_if_else_test.cc	Adds coverage ensuring parameterized types only exact-match when identical and that mismatched cases fail as expected.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[pitrou]

Nit: std::move

[zanmato1984]

This is in a loop so I don't think std::move is proper here. I've changed the parameter type to const ref to eliminate the ambiguity. Thanks.

[zanmato1984]

I'll merge this after CI turns green. Thanks for reviewing @pitrou !

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 974c3fc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.