Skip to content

GH-50565: [CI][C++] Add a JNI Windows CI job - #50606

Merged
kou merged 12 commits into
apache:mainfrom
Reranko05:gh-50565-jni-win
Jul 24, 2026
Merged

GH-50565: [CI][C++] Add a JNI Windows CI job#50606
kou merged 12 commits into
apache:mainfrom
Reranko05:gh-50565-jni-win

Conversation

@Reranko05

@Reranko05 Reranko05 commented Jul 22, 2026 •
edited by kou
Loading

Copy link
Copy Markdown
Contributor

Rationale

This adds a Windows CI job for the JNI build configuration, following the existing Linux and macOS JNI CI jobs. The new job uses a dedicated CMake preset to match the build options used by the Windows JNI build.

What changes are included?

  • Add a ninja-release-jni-windows CMake preset.
  • Add a jni-windows job to cpp_extra.yml.

Copilot AI review requested due to automatic review settings July 22, 2026 15:12
Copilot AI reviewed Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50565 has been automatically assigned in GitHub to PR creator.

@Reranko05

Reranko05 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@kou Could you approve the C++ Extra workflow so that I can verify the fix?

@kou kou added the CI: Extra: C++ Run extra C++ CI label Jul 23, 2026
@Reranko05

Reranko05 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@kou The new JNI Windows job was canceled during the build. Could you please rerun it so I can verify it completes successfully?

raulcd
raulcd reviewed Jul 23, 2026
View reviewed changes
Comment thread .github/workflows/cpp_extra.yml Outdated
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 23, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 10:10
Copilot AI reviewed Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 23, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 12:20
@Reranko05
Reranko05 requested a review from pitrou as a code owner July 23, 2026 12:20
Copilot AI reviewed Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 23, 2026 12:30
Copilot AI reviewed Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI reviewed Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kou

kou commented Jul 24, 2026

Copy link
Copy Markdown
Member

Please keep the example build step. JNI build in apache/arrow-java uses find_package(Arrow) and the example build step checks it.

@kou

kou commented Jul 24, 2026

Copy link
Copy Markdown
Member

The Ubuntu job also builds the example: https://github.com/apache/arrow/actions/runs/30065810827/job/89396497420#step:7:6453

Copilot AI review requested due to automatic review settings July 24, 2026 05:52
Copilot AI reviewed Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 06:23
Copilot AI reviewed Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 06:34
Copilot AI reviewed Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Reranko05

Reranko05 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@kou I found the remaining issue. The minimal example was being configured as a Debug build, while the installed Arrow libraries were built in Release mode. Explicitly configuring the example with -DCMAKE_BUILD_TYPE=Release fixes the build.

kou
kou reviewed Jul 24, 2026
View reviewed changes
Comment thread cpp/CMakePresets.json
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 24, 2026
Copilot AI review requested due to automatic review settings July 24, 2026 07:36
Copilot AI reviewed Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 24, 2026
@Reranko05
Reranko05 requested a review from kou July 24, 2026 08:23
kou
kou approved these changes Jul 24, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

But the problem in apache/arrow-java#1243 isn't reproduced...

Could you work on apache/arrow-java#1243 in apache/arrow-java as the next step...?

@kou
kou merged commit 5a0b57a into apache:main Jul 24, 2026
65 of 66 checks passed
@kou kou removed the awaiting change review Awaiting change review label Jul 24, 2026
@kou kou mentioned this pull request Jul 24, 2026
Closed
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jul 24, 2026
@Reranko05

Reranko05 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Sure. I'll investigate apache/arrow-java#1243 soon and work on reproducing and fixing the issue there. Thanks!

@conbench-apache-arrow

conbench-apache-arrow Bot commented Jul 25, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5a0b57a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 26 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd left review comments
Copilot code review Copilot Copilot left review comments
@kou kou kou approved these changes
@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner
@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner
@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Reranko05 @kou @raulcd