Skip to content

[AMORO-4227] Refactor auto-creating iceberg tags via ProcessFactory plugin#4228

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
zhangwl9:AMORO_refact-auto_create_tag-dev
May 22, 2026
Merged

[AMORO-4227] Refactor auto-creating iceberg tags via ProcessFactory plugin#4228
zhoujinsong merged 1 commit into
apache:masterfrom
zhangwl9:AMORO_refact-auto_create_tag-dev

Conversation

@zhangwl9
Copy link
Copy Markdown
Contributor

Why are the changes needed?

Close #4227.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zhangwl9 zhangwl9 force-pushed the AMORO_refact-auto_create_tag-dev branch from b3383db to 9d0c31a Compare May 20, 2026 07:21
@github-actions github-actions Bot added type:docs Improvements or additions to documentation module:ams-server Ams server module type:build module:common labels May 20, 2026
@zhangwl9 zhangwl9 force-pushed the AMORO_refact-auto_create_tag-dev branch from 61a0a3f to e14a6a1 Compare May 20, 2026 08:04
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.13%. Comparing base (38ef381) to head (e14a6a1).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...erver/process/iceberg/TagsAutoCreatingProcess.java 26.66% 11 Missing ⚠️
.../server/process/iceberg/IcebergProcessFactory.java 78.94% 0 Missing and 4 partials ⚠️
...src/main/java/org/apache/amoro/IcebergActions.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4228      +/-   ##
============================================
+ Coverage     29.91%   30.13%   +0.22%     
- Complexity     4317     4375      +58     
============================================
  Files           677      679       +2     
  Lines         55037    55250     +213     
  Branches       7028     7086      +58     
============================================
+ Hits          16464    16650     +186     
- Misses        37337    37345       +8     
- Partials       1236     1255      +19     
Flag Coverage Δ
core 30.13% <54.28%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 99fcc08 into apache:master May 22, 2026
6 checks passed
@zhangwl9 zhangwl9 deleted the AMORO_refact-auto_create_tag-dev branch May 22, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:common type:build type:docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask]: Refactor auto-creating iceberg tags via ProcessFactory plugin

3 participants