Skip to content

[AMORO-4163][ams] Fix CommitFailedException when loading legacy mixed-iceberg tables on Iceberg 1.7.2 #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czy006 merged 1 commit into from
Apr 16, 2026
Merged

[AMORO-4163][ams] Fix CommitFailedException when loading legacy mixed-iceberg tables on Iceberg 1.7.2 #4182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ams/src/main/java/org/apache/amoro/server/table/internal/InternalMixedIcebergHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ private TableOperations newTableOperations(boolean changeStore) {

MixedHadoopTableOperations ops =
new MixedHadoopTableOperations(new Path(tableLocation), io, metaStore.getConfiguration());
org.apache.iceberg.TableMetadata current = ops.current();
// Use refresh() instead of current() so that the returned TableMetadata reference is the
// same object cached inside ops. Iceberg 1.7.x commit() starts with versionAndMetadata()
// which compares the `base` argument against the cached reference using == (reference
// equality). If current() and versionAndMetadata() return different object instances,
// commit() throws CommitFailedException even when the metadata content is identical.
org.apache.iceberg.TableMetadata current = ops.refresh();
if (current == null) {
return ops;
}
Expand Down
Loading