Skip to content

build: make surefire enableProcessChecker overridable for Windows 11 compatibility. #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmol-saxena-14 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

build: make surefire enableProcessChecker overridable for Windows 11 compatibility. #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
preventing CI from hanging indefinitely on Windows file-lock issues or
any other test that never terminates. Override per-module if needed. -->
<surefire.forkedProcessTimeout>300</surefire.forkedProcessTimeout>
<!-- Set to 'ping' on Windows 11+ where wmic is unavailable: -Dsurefire.enableProcessChecker=ping -->
<surefire.enableProcessChecker>all</surefire.enableProcessChecker>

<siteId>activemq-${project.version}</siteId>
<projectName>Apache ActiveMQ</projectName>
Expand Down Expand Up @@ -967,7 +969,7 @@
<forkCount>1</forkCount>
<reuseForks>false</reuseForks>
<forkedProcessTimeoutInSeconds>${surefire.forkedProcessTimeout}</forkedProcessTimeoutInSeconds>
<enableProcessChecker>all</enableProcessChecker>
<enableProcessChecker>${surefire.enableProcessChecker}</enableProcessChecker>
Copy link
Copy Markdown
Member

@jbonofre jbonofre Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already the case right?

My understanding is that you are using just a Maven property instead of having the setting all inline (in the test profile).

Can you elaborate?

Copy link
Copy Markdown
Contributor Author

@anmol-saxena-14 anmol-saxena-14 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is exactly what this change does.

Before, the value was hardcoded inline in the surefire plugin configuration:
<enableProcessChecker>all</enableProcessChecker>

After, it is driven by a Maven property with all as the default:
<!-- in <properties> -->
<surefire.enableProcessChecker>all</surefire.enableProcessChecker>

<!-- in surefire plugin config -->
<enableProcessChecker>${surefire.enableProcessChecker}</enableProcessChecker>

The default value is unchanged so CI and all existing environments behave identically. The only difference is that a developer on Windows 11 (where wmic is no longer available) can now override it on the command line without patching the pom:
mvn test -Dsurefire.enableProcessChecker=ping

This change follows the same pattern already used in this pom for surefire.forkedProcessTimeout and surefire.argLine.

<failIfNoTests>false</failIfNoTests>
<systemPropertyVariables>
<java.awt.headless>true</java.awt.headless>
Expand Down