fix: return 404 when requesting not existing exact version#37
Merged
antfu merged 1 commit intoantfu:mainfrom Apr 13, 2026
Merged
fix: return 404 when requesting not existing exact version#37antfu merged 1 commit intoantfu:mainfrom
antfu merged 1 commit intoantfu:mainfrom
Conversation
✅ Deploy Preview for npm-meta-info ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is relate to the PR I made in npmx: npmx-dev/npmx.dev#2383
Fixes a bug where requesting a non-existent exact version (e.g.
axios@150.150.150) returned HTTP 200 and echoed back the version string instead of returning a 404.Changes
routes/[...pkg].tswhen
spec.type === 'version', check the version exists indata.versionsMetaand throw a 404 if not.handle.tsfix batch error status propagation: read
error.statusCode ?? error.statusso errors are not downgraded to 400.index.test.tsadd test for non-existent exact version, update pre-release test to use a version that actually exists in the registry.