fix(mcp): tolerate invalid tool output schemas#26530
Open
nicolascancino wants to merge 1 commit intoanomalyco:devfrom
Open
fix(mcp): tolerate invalid tool output schemas#26530nicolascancino wants to merge 1 commit intoanomalyco:devfrom
nicolascancino wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26529
Type of change
What does this PR do?
Makes MCP tool loading resilient when a server returns a valid
tools/listresponse whoseoutputSchemacontains refs the SDK cannot resolve.The normal
client.listTools()path still runs first. If it fails with a schema reference error, OpenCode retriestools/listwith a tolerant result schema that keepsinputSchemavalidation and treatsoutputSchemaas opaque.This fixes Google Stitch-style failures where the MCP transport connects but OpenCode marks the server as failed while validating tool output schemas.
How did you verify your code works?
Result:
Screenshots / recordings
N/A — non-UI change.
Checklist