Skip to content

fix: preserve instance context for async prompts#26528

Open
qz1543706741 wants to merge 1 commit into
anomalyco:devfrom
qz1543706741:fix/prompt-async-instance-context-26526
Open

fix: preserve instance context for async prompts#26528
qz1543706741 wants to merge 1 commit into
anomalyco:devfrom
qz1543706741:fix/prompt-async-instance-context-26526

Conversation

@qz1543706741
Copy link
Copy Markdown

@qz1543706741 qz1543706741 commented May 9, 2026

Issue for this PR

Closes #26526

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

promptAsync starts prompt work in a forked background effect after returning 204.

This change captures the request's InstanceRef and WorkspaceRef before forking, then provides them to the background prompt effect. That keeps async prompt execution on the same instance/workspace context as the HTTP request, so project-specific config such as custom agents remains available.

How did you verify your code works?

  • Confirmed the patch is limited to packages/opencode/src/server/routes/instance/httpapi/handlers/session.ts.
  • Ran git diff --check successfully.
  • Ran bun typecheck from packages/opencode; it starts successfully but currently fails on upstream dev with an unrelated existing error in src/bus/global.ts (GlobalBusEmitter.emit signature mismatch). This change does not touch that file.

Screenshots / recordings

Not applicable. This is a server-side context propagation fix.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels May 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

promptAsync background work can lose request instance context

1 participant