fix(ui): make markdown <hr> visible using --markdown-horizontal-rule token#26497
Open
chofuhoyu wants to merge 1 commit intoanomalyco:devfrom
Open
fix(ui): make markdown <hr> visible using --markdown-horizontal-rule token#26497chofuhoyu wants to merge 1 commit intoanomalyco:devfrom
<hr> visible using --markdown-horizontal-rule token#26497chofuhoyu wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25116
Type of change
What does this PR do?
Having a horizontal rule is very common in markdown rendering. I changed the default
<hr>CSS elements to make it work as expected, not a blank gap.I also utilize the
--markdown-horizontal-ruletoken for this color to make themes able to change the color of the horizontal rule.How did you verify your code works?
I built and ran opencode locally. All in all those CSS changes won't actually break any logic.
Screenshots / recordings
Before
After
Checklist