fix(opencode): use canonical GitHub action share links#26437
Open
cuevaio wants to merge 4 commits intoanomalyco:devfrom
Open
fix(opencode): use canonical GitHub action share links#26437cuevaio wants to merge 4 commits intoanomalyco:devfrom
cuevaio wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #26431: fix(github): use canonical share URL from API instead of constructing it Why it's related: This PR appears to address the same issue - using canonical share URLs from the API instead of constructing them manually. Both PRs are fixing the problem where GitHub action links were being built incorrectly and need to use the proper canonical URL format from the share service (e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26417
Type of change
What does this PR do?
GitHub action bot comments were building opencode session links from the session id as
https://opencode.ai/s/<id>. That route now returns 404.This changes the active
opencode github runpath to use the canonical URL returned by the share service, such ashttps://opncd.ai/share/<id>, for the footer link and duplicate-share detection. The legacygithub/index.tsaction entrypoint is updated the same way for consistency. The social-card image still uses the share id, derived from the canonical share URL.This works because the share API is already the source of truth for the public URL format. The GitHub action no longer guesses the host or route.
How did you verify your code works?
bun test test/cli/github-action.test.ts test/cli/import.test.ts test/share/share-next.test.tsbun typecheckbun turbo typecheckScreenshots / recordings
N/A, this is not a UI change.
Checklist