Skip to content

refactor: remove legacy importer and exporter #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrislongros wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: remove legacy importer and exporter #5153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c953d8
fix: prevent path traversal in apkg media import
chrislongros Jul 14, 2026
e41f234
refactor: remove the legacy importer
chrislongros Jul 17, 2026
2f0f2ff
refactor: remove the legacy exporter
chrislongros Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ exclude = (pylib/anki/_vendor)

[mypy-anki.*]
disallow_untyped_defs = True
[mypy-anki.importing.*]
disallow_untyped_defs = False
[mypy-anki.exporting]
disallow_untyped_defs = False
[mypy-aqt]
strict_optional = True
[mypy-aqt.browser.*]
Expand All @@ -40,8 +36,6 @@ strict_optional = True
strict_optional = True
[mypy-aqt.editor]
strict_optional = True
[mypy-aqt.importing]
strict_optional = True
[mypy-aqt.preferences]
strict_optional = True
[mypy-aqt.overview]
Expand Down
28 changes: 17 additions & 11 deletions docs-site/addons/hooks-reference.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,27 @@ instead.

---

### `media_files_did_export`
### `media_files_did_export` _(Obsolete)_

**Args:** <code>count: int</code>

Only used by legacy .apkg exporter. Will be deprecated in the future.
<Warning>

Obsolete, do not use.

</Warning>

---

### `legacy_export_progress`
### `legacy_export_progress` _(Obsolete)_

**Args:** <code>progress: str</code>

Temporary hook used in transition to new import/export code.
<Warning>

Obsolete, do not use.

</Warning>

---

Expand Down Expand Up @@ -118,17 +126,15 @@ Can modify the resulting text after rendering completes.

---

### `importing_importers`
### `importing_importers` _(Obsolete)_

**Args:** <code>importers: list[tuple[str, Any]]</code>

Allows updating the list of importers.
The resulting list is not saved and should be changed each time the
filter is called.
<Warning>
Obsolete, do not use.

NOTE: Updates to the import/export code are expected in the coming
months, and this hook may be replaced with another solution at that
time. Tracked on https://github.com/ankitects/anki/issues/1018
</Warning>

Comment on lines -129 to 132

@GithubAnon0000 GithubAnon0000 Jul 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is issue #1018 still relevant or can it be closed by this PR?

---

Expand Down
Loading
Loading