Fix mathjax wrap newline handling and add regression test#5107
Open
Arthur-Milchior wants to merge 1 commit into
Open
Fix mathjax wrap newline handling and add regression test#5107Arthur-Milchior wants to merge 1 commit into
Arthur-Milchior wants to merge 1 commit into
Conversation
If you start by writing the mathjax and then wrapping it with the mathjax tools, the new lines are incorrectly rendered as `<br>`. This problem exists generally with any formatting, but in my experience, the new line case is the most common one. In particular because there is currently zero way to add the new line properly before wrapping the math in mathjax. Further correction will wait until someone with decision power give feedback on the issue request. This change is done with a simple search and replace and not parsing HTML, for the sake of the simplicity, and to ensure this still works if HTML is somehow badly formatted. Bug ankitects#5106
Contributor
Author
As far as I can see, the current CI error in unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you start by writing the mathjax and then wrapping it with the mathjax tools, the new lines are incorrectly rendered as
<br>. This problem exists generally with any formatting, but in my experience, the new line case is the most common one. In particular because there is currently zero way to add the new line properly before wrapping the math in mathjax.Further correction will wait until someone with decision power give feedback on the issue request.
This change is done with a simple search and replace and not parsing HTML, for the sake of the simplicity, and to ensure this still works if HTML is somehow badly formatted.
Refs #5106