fix: mirror help icon for arabic script rtl langs#5105
Open
iDavi wants to merge 2 commits into
Open
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: mirror help icon for Arabic-script languages
Linked issue (required)
Refs #4749
Summary / motivation (required)
The help icon (info circle) in HelpModal was not mirrored for Arabic-script languages (Arabic, Persian). This PR adds a
flipXprop to the Badge component wrapping the icon when the user's language uses Arabic script, matching the existing RTL mirroring behavior applied elsewhere in the UI.https://en.wikipedia.org/wiki/Question_mark

Steps to reproduce (required)
How to test (required)
Checklist (minimum)
./ninja checkor an equivalent relevant check locally.I added tests because this change don't fit any of the cases where tests arent required in CONTRIBUTING.md
Before / after behavior (optional)
Before:

After: Help icon is horizontally flipped for Arabic and Persian language users, consistent with other RTL mirroring.
Scope