Skip to content

fix: mirror help icon for arabic script rtl langs#5105

Open
iDavi wants to merge 2 commits into
ankitects:mainfrom
iDavi:mirror-help-arabic-script
Open

fix: mirror help icon for arabic script rtl langs#5105
iDavi wants to merge 2 commits into
ankitects:mainfrom
iDavi:mirror-help-arabic-script

Conversation

@iDavi

@iDavi iDavi commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

fix: mirror help icon for Arabic-script languages

Linked issue (required)

Refs #4749

Summary / motivation (required)

The help icon (info circle) in HelpModal was not mirrored for Arabic-script languages (Arabic, Persian). This PR adds a flipX prop to the Badge component wrapping the icon when the user's language uses Arabic script, matching the existing RTL mirroring behavior applied elsewhere in the UI.

https://en.wikipedia.org/wiki/Question_mark
image

Steps to reproduce (required)

  1. Switch Anki's language to Arabic or Persian.
  2. Open any dialog that shows the help badge (e.g., deck options).
  3. Observe the info circle icon is not horizontally flipped.
  4. Compare with other icons in RTL layouts which are properly mirrored.

How to test (required)

  1. Switch Anki's language to Arabic (ar) or Persian (fa).
  2. Open deck options or any screen containing the help modal badge.
  3. Confirm the info circle icon is mirrored (flipped horizontally).
  4. Switch back to a non-Arabic-script language (e.g., English) and confirm the icon is unflipped.

Checklist (minimum)

  • I ran ./ninja check or an equivalent relevant check locally.
  • I added or updated tests when the change is non-trivial or behavior changed.
    I added tests because this change don't fit any of the cases where tests arent required in CONTRIBUTING.md

Before / after behavior (optional)

Before:
image

After: Help icon is horizontally flipped for Arabic and Persian language users, consistent with other RTL mirroring.

image

Scope

  • This PR is focused on one change (no unrelated edits).

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant