-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: add Linux desktop launcher for dev builds #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [Desktop Entry] | ||
| Name=Anki (dev) | ||
| Comment=Spaced repetition flashcard program | ||
| Exec=bash -c 'cd ANKI_SRC && just run' | ||
| Icon=ANKI_SRC/qt/aqt/data/qt/icons/anki.png | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The icon at
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought you would want different icons for the official build vs the dev build. If you like, I can create a new Anki (dev) icon with the text "dev" overlayed over the official Anki icon. But if you don't find this dual-install (with different Desktop icons) useful, I won't go to that trouble, and won't clutter your inbox with a revised PR. |
||
| Terminal=false | ||
| Type=Application | ||
| Categories=Education; | ||
| StartupWMClass=anki | ||
|
Comment on lines
+1
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if an additional .desktop file would make sense (I don't see how), generating one with claude isn't advised. Just make a copy of the already existing file and update accordingly. Your version just causes inconcistencies.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can rewrite the tools/anki-dev.desktop file and make it a proper format-string template and populate it with the correct ANKI_SRC path during install or |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current way anki is doing this is already integrated into the desktop.
Aside from that, I don't think we should be teaching people how to pin an icon. That differs for every OS and WM and could change with major versions of OSs or WMs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I find it helpful in my own dev environment to have a live build of my dev version of Anki also integrated into my Desktop, so I know which one I'm using/testing.