Improve type for just-clone to accept primitives too#582
Open
dumbmatter wants to merge 1 commit into
Open
Conversation
T can be any primitive too, not just an object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript types for just-clone say that the input must be an object, but if you look at the code that's not true, it works fine with a primitive as well. So maybe the type should just be
Trather thanT extends object. This is what lodash uses for cloneDeep.Alternatively all the primitives could be specified like
T | number | string | ...but ifTis good enough for lodash it's probably good enough here too.