Skip to content

Apply custom lint all over modules #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jaehwa-Noh wants to merge 9 commits into
base: main
Choose a base branch
from
+145 −42
Open

Apply custom lint all over modules #2106

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7912c71
Create lint:impl module.
Jaehwa-Noh May 8, 2026
281ef87
Apply lint dedicated module.
Jaehwa-Noh May 8, 2026
7b53501
Update comment.
Jaehwa-Noh May 8, 2026
496a6bf
Update README.md
Jaehwa-Noh May 8, 2026
df7f115
Set lint on convention.
Jaehwa-Noh May 8, 2026
d55dc42
Update README
Jaehwa-Noh May 8, 2026
b8d0bf7
change check to path.
Jaehwa-Noh May 9, 2026
9d5622a
Change to compileOnly.
Jaehwa-Noh May 9, 2026
76b8a29
Update documentation.
Jaehwa-Noh May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app-nia-catalog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,18 @@ graph TB
:core:model[model]:::jvm-library
:core:ui[ui]:::android-library
end
:lint[lint]:::android-library
:app-nia-catalog[app-nia-catalog]:::android-application
:app-nia-catalog -.-> :core:designsystem
:app-nia-catalog -.-> :core:ui
:app-nia-catalog -.-> :lint
:core:analytics -.-> :lint
:core:designsystem -.-> :lint
:core:ui --> :core:analytics
:core:ui --> :core:designsystem
:core:ui --> :core:model
:core:ui -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
24 changes: 24 additions & 0 deletions app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ graph TB
:core:notifications[notifications]:::android-library
:core:ui[ui]:::android-library
end
:lint[lint]:::android-library
:benchmarks[benchmarks]:::android-test
:app[app]:::android-application

Expand All @@ -84,67 +85,90 @@ graph TB
:app -.-> :feature:settings:impl
:app -.-> :feature:topic:api
:app -.-> :feature:topic:impl
:app -.-> :lint
:app -.-> :sync:work
:benchmarks -.->|testedApks| :app
:core:analytics -.-> :lint
:core:data -.-> :core:analytics
:core:data --> :core:common
:core:data --> :core:database
:core:data --> :core:datastore
:core:data --> :core:network
:core:data -.-> :core:notifications
:core:data -.-> :lint
:core:database --> :core:model
:core:database -.-> :lint
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
:core:designsystem -.-> :lint
:core:domain --> :core:data
:core:domain --> :core:model
:core:domain -.-> :lint
:core:navigation -.-> :lint
:core:network --> :core:common
:core:network --> :core:model
:core:network -.-> :lint
:core:notifications -.-> :core:common
:core:notifications --> :core:model
:core:notifications -.-> :lint
:core:ui --> :core:analytics
:core:ui --> :core:designsystem
:core:ui --> :core:model
:core:ui -.-> :lint
:feature:bookmarks:api --> :core:navigation
:feature:bookmarks:api -.-> :lint
:feature:bookmarks:impl -.-> :core:data
:feature:bookmarks:impl -.-> :core:designsystem
:feature:bookmarks:impl -.-> :core:ui
:feature:bookmarks:impl -.-> :feature:bookmarks:api
:feature:bookmarks:impl -.-> :feature:topic:api
:feature:bookmarks:impl -.-> :lint
:feature:foryou:api --> :core:navigation
:feature:foryou:api -.-> :lint
:feature:foryou:impl -.-> :core:designsystem
:feature:foryou:impl -.-> :core:domain
:feature:foryou:impl -.-> :core:notifications
:feature:foryou:impl -.-> :core:ui
:feature:foryou:impl -.-> :feature:foryou:api
:feature:foryou:impl -.-> :feature:topic:api
:feature:foryou:impl -.-> :lint
:feature:interests:api --> :core:navigation
:feature:interests:api -.-> :lint
:feature:interests:impl -.-> :core:designsystem
:feature:interests:impl -.-> :core:domain
:feature:interests:impl -.-> :core:ui
:feature:interests:impl -.-> :feature:interests:api
:feature:interests:impl -.-> :feature:topic:api
:feature:interests:impl -.-> :lint
:feature:search:api -.-> :core:domain
:feature:search:api --> :core:navigation
:feature:search:api -.-> :lint
:feature:search:impl -.-> :core:designsystem
:feature:search:impl -.-> :core:domain
:feature:search:impl -.-> :core:ui
:feature:search:impl -.-> :feature:interests:api
:feature:search:impl -.-> :feature:search:api
:feature:search:impl -.-> :feature:topic:api
:feature:search:impl -.-> :lint
:feature:settings:impl -.-> :core:data
:feature:settings:impl -.-> :core:designsystem
:feature:settings:impl -.-> :core:ui
:feature:settings:impl -.-> :lint
:feature:topic:api -.-> :core:designsystem
:feature:topic:api --> :core:navigation
:feature:topic:api -.-> :core:ui
:feature:topic:api -.-> :lint
:feature:topic:impl -.-> :core:data
:feature:topic:impl -.-> :core:designsystem
:feature:topic:impl -.-> :core:ui
:feature:topic:impl -.-> :feature:topic:api
:feature:topic:impl -.-> :lint
:sync:work -.-> :core:analytics
:sync:work -.-> :core:data
:sync:work -.-> :core:notifications
:sync:work -.-> :lint

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
24 changes: 24 additions & 0 deletions benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ graph TB
:core:notifications[notifications]:::android-library
:core:ui[ui]:::android-library
end
:lint[lint]:::android-library
:benchmarks[benchmarks]:::android-test
:app[app]:::android-application

Expand All @@ -84,67 +85,90 @@ graph TB
:app -.-> :feature:settings:impl
:app -.-> :feature:topic:api
:app -.-> :feature:topic:impl
:app -.-> :lint
:app -.-> :sync:work
:benchmarks -.->|testedApks| :app
:core:analytics -.-> :lint
:core:data -.-> :core:analytics
:core:data --> :core:common
:core:data --> :core:database
:core:data --> :core:datastore
:core:data --> :core:network
:core:data -.-> :core:notifications
:core:data -.-> :lint
:core:database --> :core:model
:core:database -.-> :lint
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
:core:designsystem -.-> :lint
:core:domain --> :core:data
:core:domain --> :core:model
:core:domain -.-> :lint
:core:navigation -.-> :lint
:core:network --> :core:common
:core:network --> :core:model
:core:network -.-> :lint
:core:notifications -.-> :core:common
:core:notifications --> :core:model
:core:notifications -.-> :lint
:core:ui --> :core:analytics
:core:ui --> :core:designsystem
:core:ui --> :core:model
:core:ui -.-> :lint
:feature:bookmarks:api --> :core:navigation
:feature:bookmarks:api -.-> :lint
:feature:bookmarks:impl -.-> :core:data
:feature:bookmarks:impl -.-> :core:designsystem
:feature:bookmarks:impl -.-> :core:ui
:feature:bookmarks:impl -.-> :feature:bookmarks:api
:feature:bookmarks:impl -.-> :feature:topic:api
:feature:bookmarks:impl -.-> :lint
:feature:foryou:api --> :core:navigation
:feature:foryou:api -.-> :lint
:feature:foryou:impl -.-> :core:designsystem
:feature:foryou:impl -.-> :core:domain
:feature:foryou:impl -.-> :core:notifications
:feature:foryou:impl -.-> :core:ui
:feature:foryou:impl -.-> :feature:foryou:api
:feature:foryou:impl -.-> :feature:topic:api
:feature:foryou:impl -.-> :lint
:feature:interests:api --> :core:navigation
:feature:interests:api -.-> :lint
:feature:interests:impl -.-> :core:designsystem
:feature:interests:impl -.-> :core:domain
:feature:interests:impl -.-> :core:ui
:feature:interests:impl -.-> :feature:interests:api
:feature:interests:impl -.-> :feature:topic:api
:feature:interests:impl -.-> :lint
:feature:search:api -.-> :core:domain
:feature:search:api --> :core:navigation
:feature:search:api -.-> :lint
:feature:search:impl -.-> :core:designsystem
:feature:search:impl -.-> :core:domain
:feature:search:impl -.-> :core:ui
:feature:search:impl -.-> :feature:interests:api
:feature:search:impl -.-> :feature:search:api
:feature:search:impl -.-> :feature:topic:api
:feature:search:impl -.-> :lint
:feature:settings:impl -.-> :core:data
:feature:settings:impl -.-> :core:designsystem
:feature:settings:impl -.-> :core:ui
:feature:settings:impl -.-> :lint
:feature:topic:api -.-> :core:designsystem
:feature:topic:api --> :core:navigation
:feature:topic:api -.-> :core:ui
:feature:topic:api -.-> :lint
:feature:topic:impl -.-> :core:data
:feature:topic:impl -.-> :core:designsystem
:feature:topic:impl -.-> :core:ui
:feature:topic:impl -.-> :feature:topic:api
:feature:topic:impl -.-> :lint
:sync:work -.-> :core:analytics
:sync:work -.-> :core:data
:sync:work -.-> :core:notifications
:sync:work -.-> :lint

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
5 changes: 5 additions & 0 deletions build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.apply
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.dependencies

abstract class AndroidApplicationConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
Expand All @@ -44,6 +45,10 @@ abstract class AndroidApplicationConventionPlugin : Plugin<Project> {
configureBadgingTasks(this)
}
configureSpotlessForAndroid()

dependencies {
"implementation"(project(":lint"))
Comment thread
Jaehwa-Noh marked this conversation as resolved.
Outdated
}
}
}
}
6 changes: 4 additions & 2 deletions build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ abstract class AndroidLibraryConventionPlugin : Plugin<Project> {
}
configureSpotlessForAndroid()
dependencies {
"androidTestImplementation"(libs.findLibrary("kotlin.test").get())
if (project.name != "lint") "implementation"(project(":lint"))
Comment thread
Jaehwa-Noh marked this conversation as resolved.
Outdated
"implementation"(libs.findLibrary("androidx.tracing.ktx").get())

"testImplementation"(libs.findLibrary("kotlin.test").get())
"testImplementation"(libs.findLibrary("junit").get())

"implementation"(libs.findLibrary("androidx.tracing.ktx").get())
"androidTestImplementation"(libs.findLibrary("kotlin.test").get())
}
}
}
Expand Down
1 change: 0 additions & 1 deletion build-logic/convention/src/main/kotlin/AndroidLintConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,5 @@ class AndroidLintConventionPlugin : Plugin<Project> {
private fun Lint.configure() {
xmlReport = true
sarifReport = true
checkDependencies = true
disable += "GradleDependency"
}
3 changes: 3 additions & 0 deletions core/analytics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ graph TB
direction TB
:core:analytics[analytics]:::android-library
end
:lint[lint]:::android-library
:core:analytics -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
8 changes: 8 additions & 0 deletions core/data-test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,30 @@ graph TB
:core:network[network]:::android-library
:core:notifications[notifications]:::android-library
end
:lint[lint]:::android-library

:core:analytics -.-> :lint
:core:data -.-> :core:analytics
:core:data --> :core:common
:core:data --> :core:database
:core:data --> :core:datastore
:core:data --> :core:network
:core:data -.-> :core:notifications
:core:data -.-> :lint
:core:data-test --> :core:data
:core:data-test -.-> :lint
:core:database --> :core:model
:core:database -.-> :lint
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
:core:network --> :core:common
:core:network --> :core:model
:core:network -.-> :lint
:core:notifications -.-> :core:common
:core:notifications --> :core:model
:core:notifications -.-> :lint

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
7 changes: 7 additions & 0 deletions core/data/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,28 @@ graph TB
:core:network[network]:::android-library
:core:notifications[notifications]:::android-library
end
:lint[lint]:::android-library

:core:analytics -.-> :lint
:core:data -.-> :core:analytics
:core:data --> :core:common
:core:data --> :core:database
:core:data --> :core:datastore
:core:data --> :core:network
:core:data -.-> :core:notifications
:core:data -.-> :lint
:core:database --> :core:model
:core:database -.-> :lint
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
:core:network --> :core:common
:core:network --> :core:model
:core:network -.-> :lint
:core:notifications -.-> :core:common
:core:notifications --> :core:model
:core:notifications -.-> :lint

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
2 changes: 2 additions & 0 deletions core/database/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ graph TB
:core:database[database]:::android-library
:core:model[model]:::jvm-library
end
:lint[lint]:::android-library
:core:database --> :core:model
:core:database -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
3 changes: 3 additions & 0 deletions core/datastore-test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@ graph TB
:core:datastore-test[datastore-test]:::android-library
:core:model[model]:::jvm-library
end
:lint[lint]:::android-library
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
:core:datastore-test -.-> :core:common
:core:datastore-test -.-> :core:datastore
:core:datastore-test -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
2 changes: 2 additions & 0 deletions core/datastore/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ graph TB
:core:datastore-proto[datastore-proto]:::jvm-library
:core:model[model]:::jvm-library
end
:lint[lint]:::android-library
:core:datastore -.-> :core:common
:core:datastore --> :core:datastore-proto
:core:datastore --> :core:model
:core:datastore -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
3 changes: 3 additions & 0 deletions core/designsystem/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ graph TB
direction TB
:core:designsystem[designsystem]:::android-library
end
:lint[lint]:::android-library
:core:designsystem -.-> :lint
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
Expand Down
2 changes: 0 additions & 2 deletions core/designsystem/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ android {
}

dependencies {
lintPublish(projects.lint)

api(libs.androidx.compose.foundation)
api(libs.androidx.compose.foundation.layout)
api(libs.androidx.compose.material.iconsExtended)
Expand Down
Loading
Loading